1762909 - Get rid of Adobe Flash hang handler

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[Mike Conley (:mconley) (:⚙️)]

Just stumbled on this dead code. We haven't supported Flash since the end of 2020.

We should make sure we remove any associated strings / state variables that aren't used for anything else as well.

Comment 1

[irwp]

Hi! Can you assign this bug to me? I'd like to work on it.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hi irwp! Thanks for volunteering! I can definitely assign this bug to you - but first, I just want to check: do you have a local build of Firefox ready to work with?

Comment 3

[irwp]

Hi Mike -- yes, I do. I'm an outreachy applicant and have spent the last few days getting my build together and getting the build and my various accounts in order!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Outstanding! Okay, this bug is yours! Do feel free to needinfo me if you have any questions on this, or tips on how to proceed.

Comment 5

[irwp]

Thanks so much!

Comment 6

[irwp]

Attachment: Bug 1762909 - Remove dead Flash code in BrowserGlue.jsm r=mconley

Depends on D142767

Comment 7

[irwp]

I think I got all the Flash code! Should I "push to Try" to make sure I didn't break anything? There's something in the outreachy documentation that mentions this (though says it might not be necessary).

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Yes, once the patch is settled, let's push to try with ./mach try auto to make sure nothing jumps out at us, and then we can go ahead and land this.

Comment 9

[irwp]

Hi Mike! I think I'm having some issues with Mercurial -- I suspect some of the files I'm working on have changed since I started (odd return messages from hg commit and moz-phab). Is this the right channel to ask you some questions about this?

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Yes, we can try to figure it out here - and failing that, if it ends up being lots of back and forth, we can try chatting on Matrix.

What strange messages are you seeing?

Comment 11

[irwp]

Thanks! The commit returns: "created new head". And moz-phab returned:

DAG branch point detected. Please install the evolve extension.
(https://www.mercurial-scm.org/doc/evolution/)
If you continue with --force-delete the following commits will be DELETED:
['4ce910f54955']

I then installed hg-evolve and tried moz-phab again but got the same error (DAG branch point).

[I'm on Matrix if we want to migrate our convo there]

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Hi! Yeah, let's figure this out over Matrix. I can't seem to find you, but I'm @mconley:mozilla.org, so go ahead and DM me and we'll get this sorted.

Comment 13

[irwp]

Thanks! I just dm-ed you on Matrix.

Comment 14

[irwp]

Attachment: Bug 1762909 - Remove dead Adobe Flash hang code in BrowserGlue r=mconley

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2148f12bdbf
Remove dead Adobe Flash hang code in BrowserGlue r=mconley

Comment 16

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/f2148f12bdbf