Get rid of Adobe Flash hang handler
Categories
(Firefox :: General, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: mconley, Assigned: irwp, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file, 1 obsolete file)
Just stumbled on this dead code. We haven't supported Flash since the end of 2020.
We should make sure we remove any associated strings / state variables that aren't used for anything else as well.
|
Reporter | |
Comment 2•2 years ago
|
||
Hi irwp! Thanks for volunteering! I can definitely assign this bug to you - but first, I just want to check: do you have a local build of Firefox ready to work with?
Hi Mike -- yes, I do. I'm an outreachy applicant and have spent the last few days getting my build together and getting the build and my various accounts in order!
|
|
Reporter | |
Comment 4•2 years ago
|
||
Outstanding! Okay, this bug is yours! Do feel free to needinfo me if you have any questions on this, or tips on how to proceed.
I think I got all the Flash code! Should I "push to Try" to make sure I didn't break anything? There's something in the outreachy documentation that mentions this (though says it might not be necessary).
|
|
Reporter | |
Comment 8•2 years ago
|
||
Yes, once the patch is settled, let's push to try with ./mach try auto to make sure nothing jumps out at us, and then we can go ahead and land this.
Hi Mike! I think I'm having some issues with Mercurial -- I suspect some of the files I'm working on have changed since I started (odd return messages from hg commit and moz-phab). Is this the right channel to ask you some questions about this?
|
|
Reporter | |
Comment 10•2 years ago
|
||
Yes, we can try to figure it out here - and failing that, if it ends up being lots of back and forth, we can try chatting on Matrix.
What strange messages are you seeing?
|
Assignee | |
Comment 11•2 years ago
|
||
Thanks! The commit returns: "created new head". And moz-phab returned:
DAG branch point detected. Please install the evolve extension.
(https://www.mercurial-scm.org/doc/evolution/)
If you continue with --force-delete the following commits will be DELETED:
['4ce910f54955']
I then installed hg-evolve and tried moz-phab again but got the same error (DAG branch point).
[I'm on Matrix if we want to migrate our convo there]
|
|
Reporter | |
Comment 12•2 years ago
|
||
Hi! Yeah, let's figure this out over Matrix. I can't seem to find you, but I'm @mconley:mozilla.org, so go ahead and DM me and we'll get this sorted.
|
|
Assignee | |
Comment 14•2 years ago
|
||
|
||
Updated•2 years ago
|
|
||
Comment 15•2 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f2148f12bdbf Remove dead Adobe Flash hang code in BrowserGlue r=mconley
|
|
||
Updated•2 years ago
|
|
||
Comment 16•2 years ago
|
||
| bugherder | ||
Description
•