1762932 - [wdspec] Improve BiDi specific tests for invalid types that miss `None` checks

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As noticed a couple of Webdriver Bidi tests that check for invalid types miss the None type which in most cases would be invalid because a required argument most likely shouldn't be null.

Here the list of tests that need to be checked:

https://searchfox.org/mozilla-central/search?q=_invalid_type&path=tests%2Fwebdriver%2Ftests%2Fbidi&case=false&regexp=false

Comment 1

[Alexandra Borovova [:Sasha]]

Checked the listed tests:

• https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/bidi/browsing_context/get_tree/invalid.py - None has a logic to cover it for both possible arguments (maxDepth and root), so it doesn't throw an error for both arguments;

• https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/bidi/browsing_context/navigate/invalid.py - have already checks for None for arguments context and url, wait has a default value and doesn't throw an error when it's None;

• https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/bidi/session/subscribe/subscribe.py and https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/bidi/session/unsubscribe/unsubscribe.py have already checks for None for all possible arguments;

• https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/bidi/browsing_context/close/invalid.py - the only test which is missing a valid check for None

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1762932 - Add check for `None` in invalid type test

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02de669add4a
Add check for `None` in invalid type test r=webdriver-reviewers,jdescottes

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33892 for changes under testing/web-platform/tests

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/02de669add4a

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot