1762957 - Create Fx update pinning policy and include the pin in the update URL

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, task, P2)

Description

[Robin Steuber (she/her) [:bytesized]]

This bug is for the work necessary on Firefox itself to implement update pinning. This work will involve 3 parts:

1. Adding the Enterprise Policy to the policy engine to allow Firefox to be pinned to a particular version.
2. Changing the generation of the Firefox update URL to include the update pin, if it is set. Since the update pin is optional, we will implement it as a query parameter rather than a path component. We already set a few query parameters here.
3. Adding telemetry to report the version being pinned.

Comment 1

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1762957 - Add Firefox Enterprise Policy for application update pinning r=mkaply!,bhearsum!

This patch also adds the capability for Policy implementations (in Policies.jsm) to have a validate function. If it returns false, the Enterprise Policy engine will consider the policy's parameter to be invalid and the policy will not be activated. This capability is used to validate the update pin policy's parameter to make sure that it takes the expected format ("X." or "X.Y.", where X is the pinned major version and Y is the pinned minor version).

Comment 2

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1762957 - When the AppUpdatePin policy is set, include the specified pin in the update url r=bhearsum!

Depends on D143785

Comment 3

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1762957 - Telemetry for Application Update Pinning feature r=bhearsum!

Depends on D143786

Comment 4

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1762957 - Tests for Update Pinning r=bhearsum!

Note that these tests only ensure that the pin is properly added to the update URL and to the telemetry. They do not test that the update applied will be of the correct version. This is because we are not attempting to have Firefox check if the update provided is valid given the pin, we are leaving it to the update server (Balrog) to find and serve the correct version.

Depends on D143787

Comment 5

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1762957 data review.md

Comment 6

[Robin Steuber (she/her) [:bytesized]]

Note that I am going to be holding off on merging these patches until the backend changes are ready. This is for two reasons: I can't actually test it without them, and I don't want about:policies to give the impression that this policy exists and works when it doesn't yet.

Comment 7

[Chris H-C :chutten]

Comment on attachment 9273720 [details]
Bug 1762957 data review.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Kirk Steuber is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 8

[Robin Steuber (she/her) [:bytesized]]

(In reply to Kirk Steuber (he/him) [:bytesized] from comment #6)

Note that I am going to be holding off on merging these patches until the backend changes are ready. This is for two reasons: I can't actually test it without them, and I don't want about:policies to give the impression that this policy exists and works when it doesn't yet.

We've decided not to hold these back for the backend changes, so I'll be merging this now even though the backend changes aren't quite ready yet.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14bebf899b47
Add Firefox Enterprise Policy for application update pinning r=mkaply,bhearsum,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/00f1bccb6b0f
When the AppUpdatePin policy is set, include the specified pin in the update url r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/8bed6fb08dc9
Telemetry for Application Update Pinning feature r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/b5d22712c9f6
Tests for Update Pinning r=bhearsum

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/14bebf899b47
https://hg.mozilla.org/mozilla-central/rev/00f1bccb6b0f
https://hg.mozilla.org/mozilla-central/rev/8bed6fb08dc9
https://hg.mozilla.org/mozilla-central/rev/b5d22712c9f6