1763002 - test_versioncomparator.js fails on Windows ASan Fission

Status: NEW

(Core :: XPCOM, task)

Description

[Andrew McCreight [:mccr8]]

This came up in bug 1751492.

Apparently test_comparator.js (an xpcshell test) fails with Fission. We don't run this configuration by default, so maybe it fails without Fission, too. Very bizarre. It passes on Windows opt.

Here's the failure:

(xpcshell/head.js) | test MAIN run_test pending (1)
8321499136 should be less than 0.9
Z:/task_164823805670957/build/tests/xpcshell/tests/xpcom/tests/unit/test_versioncomparator.js:run_test:42
Z:\task_164823805670957\build\tests\xpcshell\head.js:_execute_test:597
e:null:1

The only thing I can think of is that I think ASan intercepts string operations and maybe something is going wrong with that on Windows.

Comment 1

[Andrew McCreight [:mccr8]]

(The version comparator is implemented in xpcom/base/nsVersionComparator.cpp.)

Comment 2

[Andrew McCreight [:mccr8]]

Nika suggested strtol might be the issue, which led me to some googling which led to this issue about strtol not setting errno correctly in ASan on Windows. The specific case that is failing is testing the error handling of strtol. Maybe it hasn't been fixed in the last 5 years.

Comment 3

[Andrew McCreight [:mccr8]]

Or rather, here is the actual bug tracker issue.