1763107 - IsPackedArray intrinsic no longer matches C++ function

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[André Bargull [:anba]]

The intrinsic should match the C++ function. This was changed in bug 1744975 to enable Array.prototype.concat to work on tuples. But that change was actually incorrect, probably caused by a spec bug in the tuples proposal (*).

---

(*) The tuples proposal changes IsConcatSpreadable to return true for tuples. But it didn't update Array.prototype.concat to correctly work when E isn't an object: the current Array.prototype.concat spec expects that E is an object, which isn't true anymore with the proposed changes to IsConcatSpreadable.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1763107 - Part 1: Ensure IsPackedArray intrinsic matches C++ function. r=jandem!

Also update IsConcatSpreadable to match Tuple spec proposal.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1763107 - Part 2: Remove unused DefineAsIntrinsic enum. r=jandem!

Not related to part 1, just further clean-ups.

Depends on D142936

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5324c59822b
Part 1: Ensure IsPackedArray intrinsic matches C++ function. r=jandem
https://hg.mozilla.org/integration/autoland/rev/59f5742984f2
Part 2: Remove unused DefineAsIntrinsic enum. r=jandem

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d5324c59822b
https://hg.mozilla.org/mozilla-central/rev/59f5742984f2