Closed Bug 1763109 Opened 2 years ago Closed 1 year ago

waitForNavigation might return too early in Navigate.jsm

Categories

(Remote Protocol :: WebDriver BiDi, defect, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
defect
Points:
2

Tracking

(firefox107 fixed)

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m5])

Attachments

(1 file)

Bug 1763109 - [remote] ProgressListener should not resolve early if waitForExplicitStart is true
48 bytes, text/x-phabricator-request
Details | Review

With the current implementation from Bug 1730642, when we perform two navigations using wait=none the second navigation will return too early because we the webprogress will already be with isLoadingDocument = true and we will not properly wait for the next navigation to start.

To fix this we should check #waitForExplicitStart at https://searchfox.org/mozilla-central/rev/fbb1e8462ad82b0e76b5c13dd0d6280cfb69e68d/remote/shared/Navigate.jsm#209 and add more tests.

Flags: needinfo?(jdescottes)
Blocks: 1730641
Flags: needinfo?(jdescottes)

This is probably very similar or even identical to bug 1763108. But lets add as see also for now.

See Also: → 1763108

Good point, it is similar and might become a non-issue depending on what we decide with bug 1763108. But it could be interesting to fix the underlying issue in Navigate.jsm.

In Navigate.jsm terms, the bug is actually that if you create a ProgressListener with both resolveWhenStarted = true and waitForExplicitStart = true, the listener will return too soon if there is already a loading document.

I see. Could you then update the bugs summary so it reflects this particular scenario? We can then take bug 1763108 for the general use case.

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hskupin)
Summary: Fix successive calls to browsingContext.navigate with wait=none → waitForNavigation might return too early in Navigate.jsm
Severity: -- → S3
Flags: needinfo?(hskupin)
Priority: -- → P3
Whiteboard: [bidi-m3-mvp]
Points: --- → 2
Priority: P3 → P2
Whiteboard: [bidi-m3-mvp] → [webdriver:backlog]
See Also: → 1779678
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m5]
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/496f1ec38f36
[remote] ProgressListener should not resolve early if waitForExplicitStart is true r=webdriver-reviewers,whimboo

https://hg.mozilla.org/mozilla-central/rev/496f1ec38f36

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.