1763138 - MyFirefox FxA setup - Users without FxA

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[:Gijs (out for now; he/him)]

The first step in the setup flow is to show a button that opens FxA sign-up for sync (specifically: https://accounts.firefox.com/signin?context=fx_desktop_v3&entrypoint=fxa_app_menu&action=email&service=sync ).

This step shows up for users that are:

• Signed in and not verified
• Signed in previously but disconnected (d/t password reset or account disconnected)
• Not signed in

We should be able to use UIState from the sync APIs to determine this, cf. https://searchfox.org/mozilla-central/rev/fbb1e8462ad82b0e76b5c13dd0d6280cfb69e68d/browser/base/content/browser-sync.js#8

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Firefox Accounts' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[:Gijs (out for now; he/him)]

Bad bot.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1763138 - Hook up the tabs-setup flow to the sync status and fxa device list to enable the first steps. r?Dao!

• The FxA signin/signup step is wired up
• The signin with another device step to open the about:preferences deep-link is wired up

Not implemented here:

• Detecting and displaying recent remote tabs is not implemented yet
• Offline and other error conditions not handled
• We may need to wait for FxA to be ready
• Only the bare bones of markup/CSS is implemented

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c76f5df35f1
Hook up the tabs-setup flow to the sync status and fxa device list to enable the first steps. r=dao,fluent-reviewers,flod

Comment 5

[Atila Butkovits]

Backed out for causing leaks.

Backout link: https://hg.mozilla.org/integration/autoland/rev/2b5f62d669ed3de98383f5c610d43bbc0fc33d0a

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=dwFmPSn9Sf-hLKZhsYYhow.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2c76f5df35f1736acaaafcb81ab2de06fea00a34

Failure log: https://treeherder.mozilla.org/logviewer?job_id=375993293&repo=autoland&lineNumber=29624

Comment 6

[Sam Foster [:sfoster] (he/him)]

Ah, I was never calling uninit so the observers leaked. I think this should be fixed now. Thanks for the backout.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e312aa95256e
Hook up the tabs-setup flow to the sync status and fxa device list to enable the first steps. r=dao,fluent-reviewers,flod

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e312aa95256e