1763190 - Enable loading site-specific video wrapper scripts on beta and release

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, task, P1)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user launches a youtube/netflix/amazon prime video, he activates the subtitles and then launches it in the PiP, he will notice that the subtitles are NOT being displayed in the PiP.

Affected versions

• Nightly v100.0a1 and v101.0a1 - do not reproduce the issue; subs work.
• Beta v100.0b1 - REPRODUCES THE ISSUE.
• Release - disabled/not yet implemented
• ESR - disabled/not yet implemented

Affected platforms

• all

Steps to reproduce

1. Launch browser.
2. Go to about:config
3. Flip media.videocontrols.picture-in-picture.display-text-tracks.enabled to TRUE
4. Load https://www.youtube.com/watch?v=Z9zT-4mNpaE
5. Activate subtitles and launch the PiP

Expected result

• Subs are displayed in the PiP window.

Actual result

• Subs are NOT displayed in the PiP window.

Regression range

• This appears to be an issue specific to the channel because it works fine in nightly and it should also work in beta since the code rode the trains.

Additional notes

• Considering the fact that this is a channel-specific issue, I am not sure whether to flag versions; please revert if incorect.

Comment 1

[kpatenio]

It seems we restrict the creation of new video wrappers - which is needed for Netflix, Prime Video, etc. fixes - to Nightly. We need to update the imposed condition to work on beta.

Comment 2

[Ania]

Thank you for taking a look at this quickly, Katherine! Is this something we can address in a day or two to unblock the testing?

Comment 3

[kpatenio]

(In reply to amininkova from comment #2)

Thank you for taking a look at this quickly, Katherine! Is this something we can address in a day or two to unblock the testing?

This should be a quick fix and can certainly be addressed within 1-2 days. I will assign myself for the time being to get that started asap.

Comment 4

[kpatenio]

Attachment: Bug 1763190 - allow pip video wrappers for beta channel. r=#pip-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1274d9208b26
allow pip video wrappers for beta channel. r=pip-reviewers,mhowell

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/1274d9208b26

Comment 7

[Dianna Smith [:diannaS]]

:kpatenio do you want to request an uplift for this?

Comment 8

[kpatenio]

(In reply to Dianna Smith [:diannaS] from comment #7)

:kpatenio do you want to request an uplift for this?

Yes, I will make the request for an uplift

Comment 9

[kpatenio]

Comment on attachment 9270976 [details]
Bug 1763190 - allow pip video wrappers for beta channel. r=#pip-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: If declined, QA cannot test specific Picture in Picture fixes + caption/subtitles features for YouTube, Prime Video and Netflix in beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: (Taken from Bugzilla ticket)

1. Launch browser.
2. Go to about:config
3. Flip media.videocontrols.picture-in-picture.display-text-tracks.enabled to TRUE
4. Load https://www.youtube.com/watch?v=Z9zT-4mNpaE
5. Activate subtitles and launch the PiP

Expected result

• Subs are displayed in the PiP window.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change merely allows Picture in Picture video wrappers to be made regardless of build type (Nightly, Beta, etc.). If video wrappers are not created, new features and fixes are simply not applied, yet do not break Picture in Picture as a whole. These new features and fixes still depend on a preference "media.videocontrols.picture-in-picture.display-text-tracks.enabled" to be true for testing; on beta and release, it is false by default and must be enabled manually.
• String changes made/needed:

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9270976 [details]
Bug 1763190 - allow pip video wrappers for beta channel. r=#pip-reviewers!

Approved for 100.0b4

Comment 11

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c92c2e09f6fc

Comment 12

[Daniel Bodea [:danibodea]]

This fix has been verified in Beta v100.0b4 in Windows 10, Mac OS 11 and Ubuntu 20. The subtitles now work in the PiP with Youtube, Netflix, Amazon Prime in Beta channel as well. Thank you!

Will it work in the release channel as well?

Comment 13

[Ania]

Yes, thank you for verifying, Daniel.