1763214 - Cache image position

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[Morgan Reschenberg [:morgan]]

This function depends on bounds directly -- and now that we've cached bounds, we can theoretically switch this to a cached implementation too.

We could alter this function to be completely opaque:

LayoutDeviceIntPoint RemoteAccessible::ImagePosition(uint32_t aCoordType) {
    return Bounds().TopLeft();
}

... but I think we're probably better off casing off of mCachedFields for now, since there are still slight discrepancies between sync IPC bounds and cached bounds.

Comment 1

[Morgan Reschenberg [:morgan]]

Actually I don't think there's any risk to using that ^ version of the function given the sync IPC version just ends up returning Bounds().TopLeft(), which shouldn't change if we fetch Bounds() via sync IPC and then query its TopLeft(). Theoretically sending the point instead of the rect is less IPC traffic, but I don't know how much that affects performance given the overhead of doing IPC at all.
So, nevermind 😀

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1763214: Convert ImagePosition, ImageSize to use cached bounds r?eeejay

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8c1412fe13c
Convert ImagePosition, ImageSize to use cached bounds r=Jamie

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d8c1412fe13c