[wpt-sync] Sync PR 33526 - [LayoutNG] Fixedpos in abspos in inline container
Categories
(Core :: Layout, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 33526 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/33526
Details from upstream follow.
Alison Maher <almaher@microsoft.com> wrote:
[LayoutNG] Fixedpos in abspos in inline container
A fixedpos nested in a fragmented OOF would crash when its CB was
an atomic inline because we would set the
fixedpos_containing_block of the OOF ancestor to the atomic inline.
However, the containing block should not be set to an inline, but
rather to the closest parent block flow of the inline.To fix this, add a new member to the OOF node to keep track of
a fixedpos_inline_container and set the fixedpos_containing_block
once the fixedpos_inline_container's parent block flow is reached.
This allows us to make use of the same logic for handling atomic
inline CBs as we would for normal un-nested OOFs.The same issue also occurs for nested multicols, so relevant
crashing tests have been added and a similar
fixedpos_inline_container member was added to
NGMulticolWithPendingOOFs.Ref tests were not added as a part of this CL, although
I suspect the relative offset logic might be off. TODO added to
investigate this separately.Bug: 1312790
Change-Id: I236006a74e8917745cbaacbe51fc71b7e393f11b
Reviewed-on: https://chromium-review.googlesource.com/3573056
WPT-Export-Revision: 494b3291b8df66e88fb09f83e2ba288911cd71e3
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Description
•