1763468 - Deleting an event from Today Pane with `Backspace` key deletes selected message(s) instead [Mac only]

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect, P2)

Description

[Ryan Lee Sipes]

Clicked on an event in the Today Pane to delete it and when I hit the delete key on the keyboard it deleted the email I had focused.

Expectation: Assumed the last item I clicked on (and was highlighted) would be the one my keyboard commands were interacting with.

What happened: I ended up deleting a couple email messages before I realized I wasn't interacting with the element I had selected (an event in the today pane).

Comment 1

[Andrei Hajdukewycz [:sancus]]

This does not occur on the 91 branch, haven't tested betas.

Comment 2

[Thomas D. (:thomas8)]

Maybe less problematic, but essentially the same problem in the main calendar - no focus or keyboard access at all - see my bug 1717363.

Comment 3

[Geoff Lankow (:darktrojan)]

The Today Pane doesn't display a selection unless it has focus (although if the calendar colour is similar to the selection colour it can be confusing), and if it does then pressing delete appears to do what it should.

Comment 4

[Geoff Lankow (:darktrojan)]

If you go to the Delete item on the Edit menu that deletes any selected message (this code runs) even if the Today Pane has focus, which is bad. I guess if the keyboard event was somehow making it to that command the same thing would happen.

I think the simplest thing to do would be to check what has focus in the corresponding isCommandEnabled function and say if it's not inside the mail UI, return false.

Unfortunately the delete command in particular is a complete mess because it does something different in every context. It should be clearer once we've rebuilt the mail tabs.

Comment 5

[Thomas D. (:thomas8)]

First fast test on a local, editable calendar this was wfm on 101.0a1 (2022-04-06) (64-bit), Win 10.
Although exactly for the reasons mentioned by Geoff's comment 4, I'm inclined to believe that this can really happen.

Comment 6

[Thomas D. (:thomas8)]

Ryan said that this happened to him on a Mac - has someone tested this on Mac?

Comment 7

[Wayne Mery (:wsmwk)]

Antony, can you test this?

Comment 8

[Antony]

(In reply to Wayne Mery (:wsmwk) from comment #7)

Antony, can you test this?

When Task pane is open along side the message pane, even though I have selected a task, scrolled up and down to ensure focus in Task Pane, then delete a selected Task - the email highlighted in the message pane is acutally deleted, NOT the selcted Task, as noted above

using TB 102.0b2
on macOS 11.6.7 release 20g710 en-UK

Have relicated the bug

Will delete the selected task using the mouse and pop-up menu

Comment 9

[Thomas D. (:thomas8)]

Both Reporter (comment 0) and reproducer (comment 8) are on Mac, and I'm still unable to reproduce on Windows, 102.0b2 (64-bit) & 103.0a1 (2022-06-05) (64-bit), so the bug per STR of comment 0 is probably Mac only. However, the state of Edit > Delete Message (enabled even though event has focus) is error-prone on all OS per comment 4.

Comment 10

[Thomas D. (:thomas8)]

Attachment: Bug 1763468 - Handle `Backspace` on selected events in Today Pane to prevent unwanted message deletion on Mac. r=leftmostcat

Comment 11

[Thomas D. (:thomas8)]

^^ About time to get this fixed: Here's a fast fix for the worst part of this. Deleting random messages when you just want to delete an event from your agenda is dataloss (hence marked by me as P2/S2), and as Ryan pointed out in comment 0, you may not even notice what's going on, but your messages will just disappear (to the bin, but that may not help), then we get mysterious bug reports on missing messages. Let's fix this asap for 102.

We can fix the menu in a followup bug, as the menu caption is actually correct and does what it says (delete message), although it should say and do something else (delete the selected event(s)).

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/526d17e1c0cc
Handle Backspace on selected events in Today Pane to prevent unwanted message deletion on Mac. r=leftmostcat

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1fb49ace1005
follow-up lint fix. rs=bustage-fix DONTBUILD

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b0ff2773a3dd
follow-up comment fix. rs=me DONTBUILD

Comment 15

[Intermittent Failures Robot]

1 failures in 3558 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• lint: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1763468&startday=2022-12-12&endday=2022-12-18&tree=all

Comment 16

[Thomas D. (:thomas8)]

Verified fixed on Daily 110.0a1 (2023-01-07) (64-bit), macOS Monterey 12.6.

Comment 17

[Thomas D. (:thomas8)]

Comment on attachment 9307915 [details]
Bug 1763468 - Handle Backspace on selected events in Today Pane to prevent unwanted message deletion on Mac. r=leftmostcat

This causes covert dataloss of messages and should be uplifted to Beta and ESR asap.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Dataloss - On macOS, deleting an event from Today Pane with Backspace key deletes selected message(s) instead
Testing completed (on c-c, etc.): yes, on c-c
Risk to taking this patch (and alternatives if risky): zero

Comment 18

[Thomas D. (:thomas8)]

(In reply to Thomas D. (:thomas8) from comment #11)

We can fix the menu in a followup bug, as the menu caption is actually correct and does what it says (delete message), although it should say and do something else (delete the selected event(s)/task(s)).

I've filed this as Bug 1809050.

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9307915 [details]
Bug 1763468 - Handle Backspace on selected events in Today Pane to prevent unwanted message deletion on Mac. r=leftmostcat

[Triage Comment]
Approved for beta

Comment 20

[Daniel Darnell [:dandarnell]]

Thunderbird 109.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/a734c69d62a8
https://hg.mozilla.org/releases/comm-beta/rev/456ca009b874
https://hg.mozilla.org/releases/comm-beta/rev/430d82c63876

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9307915 [details]
Bug 1763468 - Handle Backspace on selected events in Today Pane to prevent unwanted message deletion on Mac. r=leftmostcat

[Triage Comment]
approved for esr102 (even though it's not been on beta long, it's simple and not a nice behavior for Mac)

Comment 22

[Rob Lemley [:rjl]]

Thunderbird 102.7.0:
https://hg.mozilla.org/releases/comm-esr102/rev/2db56b62bd3b
https://hg.mozilla.org/releases/comm-esr102/rev/91fa2b7c5b51
https://hg.mozilla.org/releases/comm-esr102/rev/a786f143946e