1763520 - Add new attribute for callbacks to mark them "can-run-script"

Status: NEW

(Developer Infrastructure :: Source Code Analysis, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I realized that there is no check to call callbacks which may run script. For example,
HTMLEditor::CreateAndInsertElement calls aInitializer which may run script. However, you can change this call:

rv = aInitializer(*this, *newElement, aPointToInsert);

to:

HTMLEditor* self = this;
rv = aInitializer(*self, *newElement, aPointToInsert);

I think that the argument should be able to marked as "can-run-script" or should assume that any callbacks of MOZ_CAN_RUN_SCRIPT methods are dangerous. And "can-run-script" lambdas should be acceptable by "can-run-script" methods.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.