1763576 - Document stackframe management and source selection in debugger codebase

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Stackframe management (fetch and map) is done in three distinct places differently without much inline comment.
Similarly, the various methods to select a source/location are missing some jsdoc as they behavior around generated/original source is non-trivial.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1763576 - [devtools] Document stackframe management in debugger frontend.

When selecting another thread/target, we shouldn't need to re-fetch frames/scopes.
This should always be done when paused() action is fired and data be stored and kept in the reducer.
But... this happen to be cancelled in middle of the processing when two thread pause concurrently.
This is experience by browser_dbg-windowless-workers.js.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1763576 - [devtools] Document source selection in debugger frontend.

I especially highlight the special behavior where the frontend tries
to keep selecting original source if we were already selecting an original source
and do the same when we were on a generated source.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1763576 - [devtools] Remove unnecessary await on synchronous dispatches.

When dispatching a JS Object, this won't be dispatching an async action.
Dropping the await will better highlight the synchronous dispatch calls.
Note that when we do

dispatch({
  [PROMISE]: ...,
  ...
});

The promise middleware kicks in and the action becomes async.
So await is still relevant in front of these dispatches.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d006a88ef4c2
[devtools] Document stackframe management in debugger frontend. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/7ee0b1be33d9
[devtools] Document source selection in debugger frontend. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/c95859201259
[devtools] Remove unnecessary await on synchronous dispatches. r=bomsy

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d006a88ef4c2
https://hg.mozilla.org/mozilla-central/rev/7ee0b1be33d9
https://hg.mozilla.org/mozilla-central/rev/c95859201259