1763587 - Encryption state not shown if user couldn't have started encryption

Status: RESOLVED FIXED

(Chat Core :: Matrix, defect)

Description

[Martin Giger [:freaktechnik]]

We currently mark a room as not supporting encryption if the user couldn't have enabled encryption in it. However, if the room already has encryption enabled that no longer matters.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1763587 - Fix Matrix room encryption state when room is already encrypted. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/78db80b6518e
Fix Matrix room encryption state when room is already encrypted. r=john.bieling

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9271255 [details]
Bug 1763587 - Fix Matrix room encryption state when room is already encrypted. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Some encrypted Matrix conversations will not show the encryption status in the right sidebar of the window
Testing completed (on c-c, etc.): Fully covered by unit tests, verified behavior on c-c.
Risk to taking this patch (and alternatives if risky): I think this is very low risk

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9271255 [details]
Bug 1763587 - Fix Matrix room encryption state when room is already encrypted. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 100.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/40775047bcf8