1763618 - The “Create New Login” button on “about:logins” is not visible at smaller window sizes

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: Screen Recording 2022-04-07 at 7.19.34 AM.mov

[Affected Versions]:

• Firefox Beta 100.b2 (Build ID: 20220405224846)
• Firefox Nightly 101.0a1 (Build ID: 20220407092959)

[Affected Platforms]:

• Windows 10
• macOS 12.6
• Linux Mint 20.2

[Prerequisites]:

• Have Firefox Beta or Nightly open.

[Steps to reproduce]:

1. Go to “about:logins”.
2. Resize the window.
3. Observe the “Create New Login” button.

[Expected result]:

• The button is visible at all window sizes.

[Actual result]:

• The button is not visible at smaller window sizes.

[Regression window]:

• Based on Mozregression results, Bug 1756387 might be the cause of this regression.
  Last good revision: d528e2ab196487485307090df140cf01cd7811f7
  First bad revision: f6a7c3a10556ba3da2d46e1ac9f772e74b0d815a
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d528e2ab196487485307090df140cf01cd7811f7&tochange=f6a7c3a10556ba3da2d46e1ac9f772e74b0d815a

[Notes]:

• On the MacBook Air device I use, the button was not displayed with a full screen window and default zoom.
• The button becomes visible when you zoom out.
• The issue is not reproducible on Firefox Release 99.0 (Build ID: 20220330194208).
• Attached is a recording of the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1756387

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:tgiles, since you are the author of the regressor, bug 1756387, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Tim Giles [:tgiles]]

Attachment: Bug 1763618 - Add overflow to login intro illustration so that layout will shrink accordingly when zoomed in. r=sgalich

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/832f6c5fd800
Add overflow to login intro illustration so that layout will shrink accordingly when zoomed in. r=sgalich

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/832f6c5fd800

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tgiles, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the issue is no longer reproducible. The button is displayed for smaller window sizes. There is a point at which it can no longer be used, but the window has to be extremely small for that to happen. Tested on Firefox Nightly 101.0a1 (Build ID: 20220411094830) on Windows 10, macOS 11.6 and Linux Mint 20.2.