Closed
Bug 1763717
Opened 3 years ago
Closed 3 years ago
Update PiP text-tracks bottom multiplier to match texttracks.css variable `--font-scale`
Categories
(Toolkit :: Picture-in-Picture, task, P3)
Toolkit
Picture-in-Picture
Tracking
()
RESOLVED
FIXED
101 Branch
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: kpatenio, Assigned: janvi01)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
In PictureInPictureChild.jsm, we have a variable TEXT_TRACKS_STYLE_BOTTOM_MULTIPLIER that we use to detect overlap between the PiP texttracks container and the PiP player controls. It is currently hardcoded, but the scaling multiplier in texttracks.css is dynamic and depends on the PiP captions font-size we set.
We should update TEXT_TRACKS_STYLE_BOTTOM_MULTIPLIER to match the --font-scale variable in the css file.
|
Assignee | |
Comment 1•3 years ago
|
||
Hey, I would like to work on this.
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → janvibajo1
Status: NEW → ASSIGNED
|
||
Comment 3•3 years ago
|
||
I would like to be assigned this task
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/91f7ed90fef7
Updated PiP text-tracks bottom multiplier r=kpatenio
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox101:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•