Closed Bug 1763783 Opened 3 years ago Closed 3 years ago

Update our in-tree ICU to 71

Tracking

()

Status:

RESOLVED FIXED

Milestone:

101 Branch

Tracking Flags:

Tracking

Status

firefox101

---

fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(11 files)

Bug 1763783 - Part 1: Remove no longer needed ICU patch. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1763783 - Part 2: Update in-tree ICU to release 71.1. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1763783 - Part 3: Update time zone data to tzdata2022a. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1763783 - Part 4: Update language tags mappings to CLDR 41. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1763783 - Part 5: Update numbering systems to CLDR 41. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1763783 - Part 6: Update currency units. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1763783 - Part 7: Update expected test results. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1763783 - Part 8: Bump minimum required ICU version to 71.1. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1763783 - Part 9: Update ICU draft API guards. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1763783 - Part 10: Remove no longer needed workarounds for ICU-21154 and ICU-21155. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1763783 - Part 11: Updating ICU requires a clobber. r=#platform-i18n-reviewers! 3 years ago André Bargull [:anba] 48 bytes, text/x-phabricator-request		Details \| Review

André Bargull [:anba]

Assignee

Description

•

3 years ago

Also updates to CLDR 41 and brings various bug fixes and improvements.

Release notes: https://icu.unicode.org/download/71

André Bargull [:anba]

Assignee

Comment 1

•

3 years ago

Attached file Bug 1763783 - Part 1: Remove no longer needed ICU patch. r=#platform-i18n-reviewers! — Details

UNUM_APPROXIMATELY_SIGN_FIELD is now available as a draft API in ICU itself.

André Bargull [:anba]

Assignee

Comment 2

•

3 years ago

Attached file Bug 1763783 - Part 2: Update in-tree ICU to release 71.1. r=#platform-i18n-reviewers! — Details

Depends on D143273

André Bargull [:anba]

Assignee

Comment 3

•

3 years ago

Attached file Bug 1763783 - Part 3: Update time zone data to tzdata2022a. r=#platform-i18n-reviewers! — Details

Depends on D143275

André Bargull [:anba]

Assignee

Comment 4

•

3 years ago

Attached file Bug 1763783 - Part 4: Update language tags mappings to CLDR 41. r=#platform-i18n-reviewers! — Details

Depends on D143276

André Bargull [:anba]

Assignee

Comment 5

•

3 years ago

Attached file Bug 1763783 - Part 5: Update numbering systems to CLDR 41. r=#platform-i18n-reviewers! — Details

Depends on D143277

André Bargull [:anba]

Assignee

Comment 6

•

3 years ago

Attached file Bug 1763783 - Part 6: Update currency units. r=#platform-i18n-reviewers! — Details

No actual data changes are present.

Depends on D143278

André Bargull [:anba]

Assignee

Comment 7

•

3 years ago

Attached file Bug 1763783 - Part 7: Update expected test results. r=#platform-i18n-reviewers! — Details

Depends on D143279

André Bargull [:anba]

Assignee

Comment 8

•

3 years ago

Attached file Bug 1763783 - Part 8: Bump minimum required ICU version to 71.1. r=#platform-i18n-reviewers! — Details

Require at least 71.1 for UNUM_APPROXIMATELY_SIGN_FIELD.

Depends on D143280

André Bargull [:anba]

Assignee

Comment 9

•

3 years ago

Attached file Bug 1763783 - Part 9: Update ICU draft API guards. r=#platform-i18n-reviewers! — Details

UCAL_TZ_LOCAL_FORMER and UCAL_TZ_LOCAL_FORMER are now stable.
UNUM_APPROXIMATELY_SIGN_FIELD is a new draft API.

Depends on D143281

André Bargull [:anba]

Assignee

Comment 10

•

3 years ago

Attached file Bug 1763783 - Part 10: Remove no longer needed workarounds for ICU-21154 and ICU-21155. r=#platform-i18n-reviewers! — Details

ICU-21154 and ICU-21155 have been fixed in ICU 71, so we can remove this
workaround.

Depends on D143282

André Bargull [:anba]

Assignee

Comment 11

•

3 years ago

Attached file Bug 1763783 - Part 11: Updating ICU requires a clobber. r=#platform-i18n-reviewers! — Details

Depends on D143283

Pulsebot

Comment 12

•

3 years ago

Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8c45437d1136 Part 1: Remove no longer needed ICU patch. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/4d8b84842e34 Part 2: Update in-tree ICU to release 71.1. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/b17cfc9dda12 Part 3: Update time zone data to tzdata2022a. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/cb7ea7f5d5c7 Part 4: Update language tags mappings to CLDR 41. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/8308dfec4d4f Part 5: Update numbering systems to CLDR 41. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/10c435662b3c Part 6: Update currency units. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/1ef8335cceca Part 7: Update expected test results. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/ff5f35f83b2a Part 8: Bump minimum required ICU version to 71.1. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/27c4895e1b2f Part 9: Update ICU draft API guards. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/3ae303350839 Part 10: Remove no longer needed workarounds for ICU-21154 and ICU-21155. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/9f69cfa948a3 Part 11: Updating ICU requires a clobber. r=platform-i18n-reviewers,jfkthame

Cosmin Sabou [:CosminS]

Comment 13

•

3 years ago

Backed out for causing spidermonkey bustages.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=9f69cfa948a3d7cd5fd8a6917d6c397e10ad6cf3&selectedTaskRun=fNmI1vIiQwajvg-3fcZRvQ.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=373945718&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=373945686&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=373945771&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=373949428&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/73589ba814eea794b13cd4b6565d0fd4bc17b26d

Flags: needinfo?(andrebargull)

André Bargull [:anba]

Assignee

Comment 14

•

3 years ago

Conflicts through new tests added in bug 1763609.

Flags: needinfo?(andrebargull)

Pulsebot

Comment 15

•

3 years ago

Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4e1b4f534ef3 Part 1: Remove no longer needed ICU patch. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/2dbde3cbe83f Part 2: Update in-tree ICU to release 71.1. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/93ae1a6eb7bf Part 3: Update time zone data to tzdata2022a. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/4d644dd00eef Part 4: Update language tags mappings to CLDR 41. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/7e52957767f3 Part 5: Update numbering systems to CLDR 41. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/c962d5a21386 Part 6: Update currency units. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/9fe82aa4c54d Part 7: Update expected test results. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/3fe967e865ae Part 8: Bump minimum required ICU version to 71.1. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/d329bf8632f1 Part 9: Update ICU draft API guards. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/c3fe952dceba Part 10: Remove no longer needed workarounds for ICU-21154 and ICU-21155. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/d59f3e298bc1 Part 11: Updating ICU requires a clobber. r=platform-i18n-reviewers,jfkthame

Sandor Molnar[:smolnar]

Comment 16

•

3 years ago

•

Edited

Backed out 11 changesets (bug 1763783) for causing spider monkey bustages.

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=910dd6e453e8fcea9e6b0b43fa1432970538a7e8

Push with failures

Failure log sm
Failure log build bustage #1
Failure log build bustage #2

Flags: needinfo?(andrebargull)

André Bargull [:anba]

Assignee

Comment 17

•

3 years ago

Due to bug 1709608, the data file was replaced with an empty file.

Flags: needinfo?(andrebargull)

Pulsebot

Comment 18

•

3 years ago

Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a2a8cd91233c Part 1: Remove no longer needed ICU patch. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/51e22286e481 Part 2: Update in-tree ICU to release 71.1. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/81c196a9f7c5 Part 3: Update time zone data to tzdata2022a. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/e346cf03c468 Part 4: Update language tags mappings to CLDR 41. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/42ef2c926e71 Part 5: Update numbering systems to CLDR 41. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/5d3f1290d8ba Part 6: Update currency units. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/e8a743f53265 Part 7: Update expected test results. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/e0dc696a1d53 Part 8: Bump minimum required ICU version to 71.1. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/89b4fcf7e929 Part 9: Update ICU draft API guards. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/ed05d313926c Part 10: Remove no longer needed workarounds for ICU-21154 and ICU-21155. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/87e552902463 Part 11: Updating ICU requires a clobber. r=platform-i18n-reviewers,jfkthame

Marian-Vasile Laza

Comment 19

•

3 years ago

Backed out 11 changesets (Bug 1763783) for causing gtest failures.
Backout link
Push with failures - GTest
Failure Log

Flags: needinfo?(andrebargull)

André Bargull [:anba]

Assignee

Comment 20

•

3 years ago

Updated gtest. Hopefully it'll now finally stick...

Flags: needinfo?(andrebargull)

Pulsebot

Comment 21

•

3 years ago

Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ffdc55819dd9 Part 1: Remove no longer needed ICU patch. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/607eef69be40 Part 2: Update in-tree ICU to release 71.1. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/c2a0f8e6e012 Part 3: Update time zone data to tzdata2022a. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/00cd1751d97b Part 4: Update language tags mappings to CLDR 41. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/4176406b2766 Part 5: Update numbering systems to CLDR 41. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/56ddf12f798c Part 6: Update currency units. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/f721a43e6384 Part 7: Update expected test results. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/976621a0fe7f Part 8: Bump minimum required ICU version to 71.1. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/272c983fb05d Part 9: Update ICU draft API guards. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/05b5f72d15bf Part 10: Remove no longer needed workarounds for ICU-21154 and ICU-21155. r=platform-i18n-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/2f80e5991c9e Part 11: Updating ICU requires a clobber. r=platform-i18n-reviewers,jfkthame

Cristian Tuns

Comment 22

•

3 years ago

bugherder

Status: ASSIGNED → RESOLVED

Closed: 3 years ago

status-firefox101: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → 101 Branch

Andra Esanu (needinfo me)

Updated

•

3 years ago

Regressions: 1764693

André Bargull [:anba]

Assignee

Updated

•

2 years ago

Duplicate of this bug: 1762862

You need to log in before you can comment on or make changes to this bug.