1763831 - Improve handling of init-operations in SetPropIRGenerator

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P1)

Description

[André Bargull [:anba]]

Init-operations (JSOp::Init{Hidden,Locked}(Prop,Elem)) in SetPropIRGenerator sometimes perform additionally work which isn't necessary when defining own properties, for example prototype guards are emitted. Let's improve this!

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1763831 - Part 1: Don't guard on prototype shapes when emitting an init-prop operation. r=iain!

We don't have to guard the prototype chain when adding an own property.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1763831 - Part 2: Return early for non-native objects in canAttachAddSlotStub(). r=iain!

Non-native objects were previously indirectly filtered through LookupOwnPropertyPure.

Depends on D143293

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1763831 - Part 3: Check exact flags when attaching an add-slot stub. r=iain!

This change allows to use the add-slot stub when adding a non-writable
property, for example through InitLockedProp or InitLockedElem.

Depends on D143294

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1763831 - Part 4: Allow non-data properties in CheckPrivateFieldIRGenerator. r=iain!

Use LookupOwnPropertyPure instead of HasOwnDataPropertyPure to match
HasPropIRGenerator.

Depends on D143295

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1763831 - Part 5: Directly call InitPropertyOperation in IonIC for IsPropertyInitOp. r=iain!

This change is no longer needed after bug 1547129.

Drive-by change:

• Change InitPropertyOperation() to accept jsbytecode* for consistency with
  InitElemOperation().

Depends on D143296

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1763831 - Part 6: Add extra assertions when only IsPropertySetOp is supported. r=iain!

Add extra assertions in preparation for part 9.

Depends on D143297

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1763831 - Part 7: Add extra assertions for dense and typed array properties. r=iain!

More assertions in preparation for part 9.

Depends on D143298

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1763831 - Part 8: Check for exact property attributes in LookupShapeForSetSlot. r=iain!

This allows to attach InitHiddenProp and InitHiddenElem when the property is non-enumerable.

Depends on D143299

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1763831 - Part 9: Remove no longer needed JSOp::InitHiddenElem restriction. r=iain!

Parts 6-7 added assertions that init-prop operations aren't used in unsupported
contexts. Part 8 changed CanAttachNativeSetSlot to check for the correct
enumerable property attribute.

These changes allow to enable attaching stubs for JSOp::InitHiddenElem.

Depends on D143300

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1763831 - Part 10: Enable InitLockedElem IC in Warp. r=iain!

There isn't any good reason to disallow InitLockedElem ICs in Warp.

Depends on D143301

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b8bdd2cad0d
Part 1: Don't guard on prototype shapes when emitting an init-prop operation. r=iain
https://hg.mozilla.org/integration/autoland/rev/e2ced4199c4b
Part 2: Return early for non-native objects in canAttachAddSlotStub(). r=iain
https://hg.mozilla.org/integration/autoland/rev/d623bd962693
Part 3: Check exact flags when attaching an add-slot stub. r=iain
https://hg.mozilla.org/integration/autoland/rev/588afdafa8a3
Part 4: Allow non-data properties in CheckPrivateFieldIRGenerator. r=iain
https://hg.mozilla.org/integration/autoland/rev/510c4b98453e
Part 5: Directly call InitPropertyOperation in IonIC for IsPropertyInitOp. r=iain
https://hg.mozilla.org/integration/autoland/rev/f8a167e3f8b6
Part 6: Add extra assertions when only IsPropertySetOp is supported. r=iain
https://hg.mozilla.org/integration/autoland/rev/6f6d0baf8a17
Part 7: Add extra assertions for dense and typed array properties. r=iain
https://hg.mozilla.org/integration/autoland/rev/931a78c9c710
Part 8: Check for exact property attributes in LookupShapeForSetSlot. r=iain
https://hg.mozilla.org/integration/autoland/rev/5f6ff39a2a62
Part 9: Remove no longer needed JSOp::InitHiddenElem restriction. r=iain
https://hg.mozilla.org/integration/autoland/rev/52c9b0b48530
Part 10: Enable InitLockedElem IC in Warp. r=iain

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4b8bdd2cad0d
https://hg.mozilla.org/mozilla-central/rev/e2ced4199c4b
https://hg.mozilla.org/mozilla-central/rev/d623bd962693
https://hg.mozilla.org/mozilla-central/rev/588afdafa8a3
https://hg.mozilla.org/mozilla-central/rev/510c4b98453e
https://hg.mozilla.org/mozilla-central/rev/f8a167e3f8b6
https://hg.mozilla.org/mozilla-central/rev/6f6d0baf8a17
https://hg.mozilla.org/mozilla-central/rev/931a78c9c710
https://hg.mozilla.org/mozilla-central/rev/5f6ff39a2a62
https://hg.mozilla.org/mozilla-central/rev/52c9b0b48530