1763907 - for external gnupg: cannot decrypt OpenPGP encrypted messages, CryptoAPI.sync() failed result: TypeError: this is undefined

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Christian Riechers]

Any attempt to decrypt OpenPGP encrypted messages fails after upgrading to TB 100.0b1. It's been working fine up to v99.0b2. No changes have been made to the profile, except the upgrade.
The private key is stored in the GnuPG keyring. When attempting to open an encrypted message I still get the Pinentry passphrase prompt, but then the message is never decrypted.
The error console has this:
CryptoAPI.sync() failed result: TypeError: this is undefined
enArmorCDataMessage chrome://openpgp/content/modules/RNP.jsm:3425
decrypt chrome://openpgp/content/modules/GPGME.jsm:136
decrypt chrome://openpgp/content/modules/RNP.jsm:1218
decrypt chrome://openpgp/content/modules/cryptoAPI/RNPCryptoAPI.jsm:233
decryptMime chrome://openpgp/content/modules/cryptoAPI/RNPCryptoAPI.jsm:260
onStopRequest chrome://openpgp/content/modules/mimeDecrypt.jsm:546
interface.js:46:17
TypeError: this is undefined
RNP.jsm:3425:5

This has been seen on both, Linux and Win10.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1763907 - decrypting with external opengpgp was broken. r=kaie

Comment 2

[Magnus Melin [:mkmelin]]

This is from https://hg.mozilla.org/comm-central/rev/d3b9394d682a - bug 1667564

Comment 3

[Kai Engert [:KaiE:]]

Christian, thanks for the report. Could you please test the fix works?

I've started a TB version 100 branch experimental build with Magnus' patch.
You can find it here:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=7847a39a5fc9d5d85056402978a31c1a87f3188c&selectedTaskRun=awT2MtsZRvmMkKY_FKiSRg.0

Click on the green B or Ba for your platform (once its green), then click "Artifacts and debugging", then download target.tar.bz2 for linux or target.zip for window.

Comment 4

[Christian Riechers]

I did install the 64-bit experimental version for Linux. The behavior is unchanged, an encrypted message still doesn't decrypt. From the error console:
CryptoAPI.sync() failed result: TypeError: this is undefined
enArmorCDataMessage chrome://openpgp/content/modules/RNP.jsm:3425
decrypt chrome://openpgp/content/modules/GPGME.jsm:136
decrypt chrome://openpgp/content/modules/RNP.jsm:1218
decrypt chrome://openpgp/content/modules/cryptoAPI/RNPCryptoAPI.jsm:233
decryptMime chrome://openpgp/content/modules/cryptoAPI/RNPCryptoAPI.jsm:260
onStopRequest chrome://openpgp/content/modules/mimeDecrypt.jsm:546
interface.js:46:17
TypeError: this is undefined
RNP.jsm:3425:5

Comment 5

[Magnus Melin [:mkmelin]]

The line numbers are exactly the same as previous, so I think that isn't using the patch. Try starting with --purgecaches if it really is the right binary

Comment 6

[Christian Riechers]

--purgecaches did the trick. Decryption now works with the experimental version.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/535ffd214012
decrypting with external opengpgp was broken. r=kaie

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9271582 [details]
Bug 1763907 - decrypting with external opengpgp was broken. r=kaie

[Approval Request Comment]
Regression caused by (bug #): 1667564
User impact if declined: Using external PGP via GPGME not working
Risk to taking this patch (and alternatives if risky): low risk, can't break the feature any more than it is

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9271582 [details]
Bug 1763907 - decrypting with external opengpgp was broken. r=kaie

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 100.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/032bb9513d87