Closed Bug 1764244 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33600 - [css-flex] Fix flex base size with aspect-ratio item in column flexbox

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33600 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33600
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css-flex] Fix flex base size with aspect-ratio item in column flexbox

We weren't sending the max-content inline size through the aspect-ratio.
We were only sending through definite specified inline sizes. But if
there isn't a specified size, we need to use max-content inline size.

There's still a sneaky bug here that's exercised in the 038 test.
Firefox has the same bug. We may decide it's a spec issue.

Bug: 1311206
Change-Id: Iad1adcf91a82127b7c91851bff7c442f505cede6
Reviewed-on: https://chromium-review.googlesource.com/3583206
WPT-Export-Revision: cc23c6861849ee51943d041c2cd9b39aedc762d9

Component: web-platform-tests → Layout
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0af9058ca121
[wpt PR 33600] - [css-flex] Fix flex base size with aspect-ratio item in column flexbox, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b189b7e34d0e
[wpt PR 33600] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.