1764439 - Handle errors in custom formatters

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Sebastian Zartner [:sebo]]

If the definition of a custom formatter is incorrect or throws an error, that error should be logged to the console.

Such errors can be an incorrect JsonML returned by the header or body method or an exception thrown by any of the methods.

Sebastian

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: WIP: Bug 1764439 - [devtools] Handle errors in custom formatters.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Sebastian, here's what it could look like, at least for errors caused by faulty header functions: https://phabricator.services.mozilla.com/D155480
Script url, line and columns seems to be available so we can populate the nsIScriptError object with it.
Hope this helps, don't hesitate to ping me if you have any question about this.

Comment 3

[Sebastian Zartner [:sebo]]

Thank you Nicolas! I will have a look into this.

Sebastian

Comment 4

[Sebastian Zartner [:sebo]]

Attachment: Bug 1764439 - Handled errors in custom formatters. r=nchevobbe

Errors in custom formatters are now logged to the web console to notify users so they can correct the errors.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60fd58f8b289
Handled errors in custom formatters. r=nchevobbe

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/60fd58f8b289