1764452 - tabs.onUpdated spamming with {attention:false} when changing selected tab

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect)

Description

[Oriol Brufau [:Oriol]]

Just by selecting different tabs, extensions get spammed with { attention: false }.

Selecting another tab should only trigger tabs.onActivated and tabs.onHighlighted events.

1. Inspect some extension and run

   browser.tabs.onUpdated.addListener(console.log.bind(console, "onUpdated")); 
   

2. Open browser console

3. Change selected tab a few times

4. The browser console will show the logs

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1764452 - Avoid tabs.onUpdated events for 'attention' when value doesn't change. r?Gijs,mixedpuppy

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e64a440f0c8b
Avoid tabs.onUpdated events for 'attention' when value doesn't change. r=Gijs,mixedpuppy

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e64a440f0c8b

Comment 4

[Andrej (:aglavic)]

== Change summary for alert #33924 (as of Mon, 25 Apr 2022 17:57:30 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
4%	tabswitch	windows10-64-shippable-qr	e10s fission stylo webrender-sw	7.56 -> 7.22
4%	tabswitch	linux1804-64-shippable-qr	e10s fission stylo webrender	7.23 -> 6.91
4%	tabswitch	windows10-64-shippable-qr	e10s fission stylo webrender	7.52 -> 7.21

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33924