1764512 - Find in page should ignore content skipped via `content-visibility`

Status: RESOLVED FIXED

(Core :: Find Backend, enhancement)

Description

[Martin Robinson (email:[e-mail])]

The specification (https://drafts.csswg.org/css-contain/#cv-notes) says that content that is skipped via content-visibility should not be accessible to find in page.

Comment 1

[Martin Robinson (email:[e-mail])]

Attachment: Bug 1764512 - Find in page should ignore content skipped via `content-visibility` r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18ff5f7245ce
Find in page should ignore content skipped via `content-visibility` r=emilio

Comment 3

[Iulian Moraru]

Backed out for causing mochitest failures.

Push with failures
Push where they appeared

Failure log

Backout link

[task 2022-04-21T09:11:33.115Z] 09:11:33     INFO - Checking for xpcshell processes...
[task 2022-04-21T09:11:33.116Z] 09:11:33     INFO - mozcrash Removed pending crash reports at '/Users/cltbld/Library/Application Support/firefox/Crash Reports'
[task 2022-04-21T09:11:34.842Z] 09:11:34    ERROR - The 'prefs' key must be set in the DEFAULT section of a manifest. Fix the following manifests: toolkit/components/find/test/mochitest/mochitest.ini
[task 2022-04-21T09:11:34.932Z] 09:11:34    ERROR - Return code: 1
[task 2022-04-21T09:11:34.933Z] 09:11:34    ERROR - No suite end message was emitted by this harness.
[task 2022-04-21T09:11:34.933Z] 09:11:34    ERROR - No checks run.
[task 2022-04-21T09:11:34.933Z] 09:11:34     INFO - TinderboxPrint: mochitest-mochitest-plain<br/><em class="testfail">T-FAIL</em>
[task 2022-04-21T09:11:34.933Z] 09:11:34    ERROR - # TBPL FAILURE #
[task 2022-04-21T09:11:34.933Z] 09:11:34  WARNING - setting return code to 2
[task 2022-04-21T09:11:34.933Z] 09:11:34    ERROR - The mochitest suite: mochitest-plain ran with return status: FAILURE
[task 2022-04-21T09:11:34.933Z] 09:11:34     INFO - Running post-action listener: _package_coverage_data
[task 2022-04-21T09:11:34.933Z] 09:11:34     INFO - Running post-action listener: _resource_record_post_action
[task 2022-04-21T09:11:34.933Z] 09:11:34     INFO - Running post-action listener: process_java_coverage_data
[task 2022-04-21T09:11:34.934Z] 09:11:34     INFO - [mozharness: 2022-04-21 09:11:34.933994Z] Finished run-tests step (success)
[task 2022-04-21T09:11:34.934Z] 09:11:34     INFO - Running post-run listener: _resource_record_post_run
[task 2022-04-21T09:11:34.996Z] 09:11:34     INFO - instance_metadata.json not found; unable to determine instance type
[task 2022-04-21T09:11:34.997Z] 09:11:34     INFO - Validating Perfherder data against /opt/worker/tasks/task_165053215714508/mozharness/external_tools/performance-artifact-schema.json
[task 2022-04-21T09:11:35.000Z] 09:11:34     INFO - PERFHERDER_DATA: {"framework": {"name": "job_resource_usage"}, "suites": [{"name": "mochitest.mochitest-plain.overall", "extraOptions": ["e10s", "buildbot-unknown"], "subtests": [{"name": "cpu_percent", "value": 13.824358974358976}, {"name": "io_write_bytes", "value": 322682880}, {"name": "io.read_bytes", "value": 65871872}, {"name": "io_write_time", "value": 574}, {"name": "io_read_time", "value": 615}]}, {"name": "mochitest.mochitest-plain.start-pulseaudio", "subtests": [{"name": "time", "value": 0.0004367828369140625}]}, {"name": "mochitest.mochitest-plain.install", "subtests": [{"name": "time", "value": 24.61291217803955}, {"name": "cpu_percent", "value": 13.928819444444445}]}, {"name": "mochitest.mochitest-plain.stage-files", "subtests": [{"name": "time", "value": 0.00033593177795410156}]}, {"name": "mochitest.mochitest-plain.run-tests", "subtests": [{"name": "time", "value": 2.2063119411468506}, {"name": "cpu_percent", "value": 9.408333333333333}]}]}
[task 2022-04-21T09:11:35.000Z] 09:11:35     INFO - Total resource usage - Wall time: 27s; CPU: 9%; Read bytes: 65871872; Write bytes: 322682880; Read time: 615; Write time: 574
[task 2022-04-21T09:11:35.000Z] 09:11:35     INFO - TinderboxPrint: CPU usage<br/>9.4%
[task 2022-04-21T09:11:35.000Z] 09:11:35     INFO - TinderboxPrint: I/O read bytes / time<br/>65,871,872 / 615
[task 2022-04-21T09:11:35.000Z] 09:11:35     INFO - TinderboxPrint: I/O write bytes / time<br/>322,682,880 / 574
[task 2022-04-21T09:11:35.000Z] 09:11:35     INFO - TinderboxPrint: CPU idle<br/>275.2 (86.2%)
[task 2022-04-21T09:11:35.000Z] 09:11:35     INFO - TinderboxPrint: CPU system<br/>5.0 (1.6%)
[task 2022-04-21T09:11:35.000Z] 09:11:35     INFO - TinderboxPrint: CPU user<br/>39.2 (12.3%)
[task 2022-04-21T09:11:35.000Z] 09:11:35     INFO - TinderboxPrint: Swap in / out<br/>522,571,776 / 0
[task 2022-04-21T09:11:35.000Z] 09:11:35     INFO - start-pulseaudio - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2022-04-21T09:11:35.000Z] 09:11:35     INFO - install - Wall time: 25s; CPU: 14%; Read bytes: 378607104; Write bytes: 321953792; Read time: 22143; Write time: 527
[task 2022-04-21T09:11:35.001Z] 09:11:35     INFO - stage-files - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2022-04-21T09:11:35.001Z] 09:11:35     INFO - run-tests - Wall time: 2s; CPU: 9%; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2022-04-21T09:11:35.009Z] 09:11:35  WARNING - returning nonzero exit status 2
[taskcluster 2022-04-21T09:11:35.039Z]    Exit Code: 2
[taskcluster 2022-04-21T09:11:35.039Z]    User Time: 1m34.869414s
[taskcluster 2022-04-21T09:11:35.039Z]  Kernel Time: 20.94364s
[taskcluster 2022-04-21T09:11:35.039Z]    Wall Time: 2m10.771653s
[taskcluster 2022-04-21T09:11:35.039Z]       Result: FAILED
[taskcluster 2022-04-21T09:11:35.039Z] === Task Finished ===
[taskcluster 2022-04-21T09:11:35.039Z] Task Duration: 2m10.776088s

Comment 4

[Martin Robinson (email:[e-mail])]

Looks like the issue is that preferences set in mochitest configuration files should be in the DEFAULT section. I've uploaded a new change fixing this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84a3fbb5efea
Find in page should ignore content skipped via `content-visibility` r=emilio

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/84a3fbb5efea