1764515 - Remove "media.block-midflight-redirects" pref

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task)

Description

[Karl Tomlinson (:karlt)]

The "media.block-midflight-redirects" was added to verify that test videos play without the blocking, but we have CORS for that.

The behavior of the code is easier to follow without the different paths from the pref.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: Bug 1764515 Remove "media.block-midflight-redirects" pref r?#media-playback-reviewers

The "media.block-midflight-redirects" was added to verify that test videos
play without the blocking,
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8c358ea16eb
but we have CORS for that.

The behavior of the code is easier to follow without the different paths from
the pref.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28ebb573c2cb
Remove "media.block-midflight-redirects" pref r=media-playback-reviewers,padenot

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/28ebb573c2cb

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 9272070 [details]
Bug 1764515 Remove "media.block-midflight-redirects" pref r?#media-playback-reviewers

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Some of the behavior that was provided by this hidden pref for testing gets disabled by attachment 9275133 [details] [diff] [review], which we'd like to uplift to esr91.
  i.e. the part of the test being removed by this patch is not compatible with the fix for bug 1735923.
• User impact if declined: Cannot fix bug 1735923, at least not without a more complicated solution.
• Fix Landed on Version: 101
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is mostly a change to testing.
  Plausibly a user might have set the pref, but that would have made them vulnerable to cross-origin leaks like bug 1441153.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9272070 [details]
Bug 1764515 Remove "media.block-midflight-redirects" pref r?#media-playback-reviewers

Approved for 91.10esr.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/442ee1b4a98f