Closed Bug 1764521 Opened 2 years ago Closed 2 years ago

Update remote/shared/test/xpcshell/test_Navigate.js for pending promise checks

Categories

(Remote Protocol :: Agent, enhancement, P3)

enhancement
Points:
1

Tracking

(firefox101 fixed)

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

Details

(Whiteboard: [bidi-m3-mvp])

Attachments

(1 file)

As discussed in https://phabricator.services.mozilla.com/D143181#inline-792049 it would be great to get all the tests in that file updated so that we also check for not yet resolved navigation promises. Right now we only do a final check when it's clear that it should be resolved.

This could look like:

const navigated = waitForInitialNavigationCompleted(webProgress);

let navigatedResolved = false;
navigated.then(() => (navigatedResolved = true));

Might still be good to have that in the M3 milestone to strengthen the navigation commands.

Points: --- → 1
Priority: -- → P3
Whiteboard: [bidi-m3-mvp]
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/064812874f37
Add pending Promise check in Navigation tests. r=webdriver-reviewers,jdescottes,whimboo
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: