1764541 - Add telemetry for window.open with empty url argument

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Michel Le Bihan]

When websites open windows without providing a URL, about:blank is shown in the urlbar of the new window. It might be difficult for users to evaluate whether they should trust the content of such window. Worse, some users might recognize the about: URL scheme and believe the opened page to be an internal browser page.

I propose to add telemetry to track usage of window.open with an empty URL parameter. If usage will be low, I think that it might be worth considering deprecating this feature and requiring a non empty URL parameter.

Comment 1

[Michel Le Bihan]

Attachment: Bug 1764541 - Add telemetry for window.open with empty url argument r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a715d529b02e
Add telemetry for window.open with empty url argument r=emilio

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a715d529b02e

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

I know it's late here, but does this also need data-review? Coming from bug 1784590.

Comment 5

[Chris H-C :chutten]

All new or expanded data collections in mozilla projects are subject to Data Collection Review. I'd say this is definitely a new or expanded data collection, so needs review.

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Thanks! In that case I guess either of the assignee or the reviewer should request it.

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

(And probably worth to review the log of https://searchfox.org/mozilla-central/source/dom/base/UseCounters.conf?)

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Hmm, I missed that, sorry. That said it isn't super-clear to me whether IDL/custom use-counters need data-r. They are by definition technical data on how a Web API is used. It seems at least a comment in UseCounters.conf would go a long way.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Delayed data-r

Comment 10

[Chris H-C :chutten]

Comment on attachment 9290357 [details]
Delayed data-r

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, the DOM Team and :emilio are responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+