1764549 - RLB's dispatcher's preinit queue size is too small for FOG

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Chris H-C :chutten]

The preinit buffer in the Glean SDKs' dispatchers is 100. I believe I remember this is to limit the max RAM impact of the SDK not being init until later in startup.

In FOG's case, Glean's operating in the same environment where Legacy Firefox Telemetry keeps everything in RAM, so a low limit isn't necessary. We might not even want any limit.

This recently came to a head where a lot of metrics tasks were being queued in a test situation, causing data loss. And there's plenty of evidence that the limit's too low in the real world, too.

Ideally we'd make this limit configurable with an option to make it limitless, but for now this bug is about bumping GLOBAL_DISPATCHER_LIMIT from 100 to 1000.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/2015

Comment 2

[Chris H-C :chutten]

badboy merged PR #2015: "bug 1764549 - Bump the RLB preinit queue from 10^2 to 10^3" in 78b6ed9.

Comment 3

[Chris H-C :chutten]

Not closing this off as we still need

1. A Glean SDK release
2. To vendor in the updated Glean SDK release

Shouldn't be too long.

Comment 4

[Chris H-C :chutten]

Attachment: Bug 1764549 - Update Glean SDK to v44.1.1 r?TravisLong!

Comment 5

[Chris H-C :chutten]

Attachment: Bug 1764549 - Don't forget to update glean-ffi's version r?TravisLong!

Depends on D143749

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a53c3c4105b7
Update Glean SDK to v44.1.1 r=TravisLong
https://hg.mozilla.org/integration/autoland/rev/63bd3eac0849
Don't forget to update glean-ffi's version r=TravisLong

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a53c3c4105b7
https://hg.mozilla.org/mozilla-central/rev/63bd3eac0849