1764571 - implement sensitive data scrubbing for sentry (antenna)

Status: RESOLVED FIXED

(Socorro :: Antenna, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We updated to sentry-sdk. Now that we're using that, we need to make sure we're not sending PII along with Sentry error reports.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this because it's blocking the migration.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I did a lot of the R&D work in bug #1764569.

There's a Sentry migration doc that contains analysis on what we need to scrub and how here:

https://docs.google.com/document/d/1sIT80jMVa11T3g2GgCSCchHrMksC71fosr9VgOqAYQM/edit#heading=h.vibvf76xo2th

We're going to use the newly developed Fillmore library (https://pypi.org/project/fillmore/) to scrub Sentry events.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 848: bug 1764571: add sentry scrubbing

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #848: "bug 1764571: add sentry scrubbing" in 8a0af18.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 849: bug 1764571: fix data in Sentry event

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

This adds "socorro.collector.app.sentry_scrub_error" metric. We need to add a dashboard for that.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 851: bug 1764571: update fillmore to 0.1.1

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #851: "bug 1764571: update fillmore to 0.1.1" in d24ac6d.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 855: bug 1764571: update fillmore to 0.1.2 and make sure it's logged

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #855: "bug 1764571: update fillmore to 0.1.2 and make sure it's logged" in 2451ade.

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this to prod in bug #1782777 just now. Sentry and grafana look fine. Any additional changes we need to make will be covered in new bugs. Marking as FIXED.