1764709 - Expiration month and year are not normalized when credit card form is using separate fields for expiration date

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Dimi Lee [:dimi]]

See here. The result is not normalized when there is no "cc-exp" in the credit card record.

Comment 1

[Dimi Lee [:dimi]]

Currently this issue doesn't affect desktop because we still normalize credit card record in the parent side. However, this issue causes us send inconsistent data to geckoview (normalized credit card record when a form is using a single "cc-exp" field, non-normalized cc record when a form is using "cc-exp-month" + "cc-exp-year".

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1760834

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:tgiles, since you are the author of the regressor, bug 1760834, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Dimi Lee [:dimi]]

:agi If we fix this issue, the information in CC recrod will always look like:

• Card Number: xxxxyyyyzzzzaaaa (hyphen and white space are removed from the number)
• Expiration Month: String 1-12 (without 0, ex 02 will become 2)
• Expiration Year: 20XX (Ex. expiration year can be 22 if the expiration year is this year)

I know AutocompleteTest.kt has to be updated because right now a lot of testcases are using non-normalized data while comparing expected result. I would also like to know whether the implementation also needs to be updated, what format geckoview expects currently.

Comment 5

[Tim Giles [:tgiles]]

I can work on fixing this. I'll just need some pointers for the AutocompleteTest.kt situation that Dimi pointed out in Comment #4.

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

(In reply to Dimi Lee [:dimi][:dlee] from comment #4)

:agi If we fix this issue, the information in CC recrod will always look like:

• Card Number: xxxxyyyyzzzzaaaa (hyphen and white space are removed from the number)
• Expiration Month: String 1-12 (without 0, ex 02 will become 2)
• Expiration Year: 20XX (Ex. currently expiration year can be 22 if the expiration year is this year)

I know AutocompleteTest.kt has to be updated because right now a lot of testcases are using non-normalized data while comparing expected result. I would also like to know whether the implementation also needs to be updated, what format geckoview expects currently.

GeckoView-wise I don't see any problems with normalizing the data like you describe. I wouldn't expect the front-end to have problems with this either, but I'm not sure. GL what do you think?

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

The normalized data looks good for mobile.

Comment 8

[Tim Giles [:tgiles]]

Attachment: Bug 1764709 - Always normalize credit card expiration month and year when creating a new record. r=agi,dimi!,sgalich!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/360f31b00167
Always normalize credit card expiration month and year when creating a new record. r=geckoview-reviewers,dimi,sgalich,agi

Comment 10

[Sandor Molnar[:smolnar]]

Backed out changeset 360f31b00167 (bug 1764709) for causing bc failures in browser_creditCard_submission_normalized.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a6d65eaa09e8d3a5bdcd6fef4b4c30060c45852d

Push with failures

Failure log

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e71ddfbf9c29
Always normalize credit card expiration month and year when creating a new record. r=geckoview-reviewers,dimi,sgalich,agi

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e71ddfbf9c29

Comment 13

[Dimi Lee [:dimi]]

We disable browser_creditCard_submission_normalized.js in apple_silicon for now, this is the same issue as Bug 1714221 Comment 54.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tgiles, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 15

[Tim Giles [:tgiles]]

:gl since this patch affects only mobile credit card autofill, do you think we should uplift this? Without the patch, there's a chance Gecko will send non-normalized data for sites that use separate expiry month and year fields. For example, if the expiry year was "2024", we will send over "24" and if expiry month was "05", we will send "05" instead of 5.

Comment 16

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Tim Giles [:tgiles] from comment #15)

:gl since this patch affects only mobile credit card autofill, do you think we should uplift this? Without the patch, there's a chance Gecko will send non-normalized data for sites that use separate expiry month and year fields. For example, if the expiry year was "2024", we will send over "24" and if expiry month was "05", we will send "05" instead of 5.

Hi, that won't be necessary since we haven't implemented save/update prompts for credit cards. We were previously depending on ensuring we were passing the credit card information correctly into GV in order to implement these prompts.