1764823 - D3D9DXVA2Manager::SupportsConfig uses output type for testing decoder instantiation, which does not match Microsoft documentation.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Zaggy1024]

In D3D9DXVA2Manager::SupportsConfig, it passes the output type to ConvertMFTypeToDXVAType, which is incorrect according to Microsoft documentation:

https://docs.microsoft.com/en-us/windows/win32/medfound/supporting-dxva-2-0-in-directshow#finding-a-decoder-configuration

// Fills in a DXVA2_VideoDesc structure based on the input format.
void FillInVideoDescription(DXVA2_VideoDesc *pDesc);

We should change SupportsConfig to be consistent with this documentation. The output media type from WMFVideoMFTManager does not have MF_MT_FRAME_RATE set, so it should either be set in WMFVideoMFTManager::SetDecoderMediaTypes(), or a placeholder/approximation should be used in SupportsConfig.

Comment 1

[Zaggy1024]

Attachment: Bug 1764823 - When attempting to hardware decode H264 video, the D3D9 DXVA support check will now correctly use the input media type. r=alwu

Improved the debug description of WMF video decoders to list the DXVA version used as well as the correct output type.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/876973cc9138
When attempting to hardware decode H264 video, the D3D9 DXVA support check will now correctly use the input media type. r=alwu

Comment 3

[Atila Butkovits]

Backed out for causing gl failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/977e4100a0776400293e3237691b614b6bcaa131

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=KjcwS3EqTva0cMnH7kX__g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=876973cc91389050c0dcf2c3d5af9143d90d38bd

Failure log:

• https://treeherder.mozilla.org/logviewer?job_id=374606007&repo=autoland&lineNumber=3707
• https://treeherder.mozilla.org/logviewer?job_id=374606344&repo=autoland&lineNumber=2206
• https://treeherder.mozilla.org/logviewer?job_id=374600541&repo=autoland&lineNumber=9216

Comment 4

[Zaggy1024]

Re-landing with a fix, it looks like there was a null reference in debug logging.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a677ce7701a6
When attempting to hardware decode H264 video, the D3D9 DXVA support check will now correctly use the input media type. r=alwu

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a677ce7701a6