1764967 - [wpt-sync] Sync PR 33656 - Migrate iframe-based Client Hint WPTs to import client hints lists

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33656 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33656
Details from upstream follow.

Victor Tan <[e-mail]> wrote:

Migrate iframe-based Client Hint WPTs to import client hints lists

Introduce two new files into "client-hints/resources" to centralize the
dependencies of client hint token lists across javascript and python
tests:

• export.js
• clienthintslist.py

Eventually all Client Hints tests will be migrated to using these lists
to pare down the number of tests touched when creating new hints; this
CL pertains to the tests that depend on
"client-hints/resources/expect-client-hints-headers-iframe.py"

One of change is the query strings fed to
"expect-client-hints-headers-iframe.py" is now generated in
"client-hints/resources/feature-policy-navigation.js".

Another change is fixing tests related to sec-ch-ua-platform since we
added platform to client hints returned by default in
getHighEntropyValues in https://crrev.com/c/3389295.

Bug: 1304740
Change-Id: Id41ddbe1ee29c10f7b7c96a283f7eca2abec438b

Reviewed-on: https://chromium-review.googlesource.com/3549556
WPT-Export-Revision: 94a98ec59af01ae66d86b945882f68ca042e4519

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 33656 applied with additional changes from upstream: 89d5523c9ef343688f4a83a63a22e84ebc010544, 1cc382010fee19778fa06d1bf0e34d3c37497067

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ccc4536a4ce523a1930525edade7d8e26127ff18

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 11 tests and 1 subtests

Status Summary

Firefox

OK : 11
PASS: 2
FAIL: 16

Chrome

OK : 11
PASS: 16
FAIL: 2

Safari

OK : 11
PASS: 2
FAIL: 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/client-hints/accept-ch/feature-policy-navigation/feature-policy.https.html
Client hints loaded on cross-origin iframe request with feature policy.: FAIL (Chrome: PASS, Safari: FAIL)
Client hints loaded on same-origin iframe request with feature policy.: FAIL (Chrome: PASS, Safari: FAIL)
Client hints loaded on cross-origin iframe request with feature policy after attempting to set independently.: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/accept-ch/feature-policy-navigation/no-feature-policy.https.html
Client hints not loaded on cross-origin iframe request with no feature policy.: FAIL (Chrome: PASS, Safari: FAIL)
Client hints loaded on same-origin iframe request with no feature policy.: FAIL (Chrome: PASS, Safari: FAIL)
Client hints loaded on cross-origin iframe request with allow list.: FAIL (Chrome: PASS, Safari: FAIL)
Client hints loaded on same-origin iframe request with allow list.: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/http-equiv-accept-ch-iframe.https.html
Client hints loaded on same-origin iframe should include hints with a default permissions policy ofself and *, but the http-equiv meta tag has a bug and it doesn't impact iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
Client hints loaded on cross-origin iframe only include hints with a default permissions policy of *.: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/meta-name-accept-ch-iframe.https.html
Client hints loaded on same-origin iframe include hints with a default permissions policy of self and *.: FAIL (Chrome: FAIL, Safari: FAIL)
Client hints loaded on cross-origin iframe only include hints with a default permissions policy of *.: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/sandbox/iframe-csp-same-origin.https.html
CSP sandboxed iframe with same-origin flag does send client hint headers: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/sandbox/iframe-csp.https.html
CSP sandboxed iframe does not send client hint headers: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/sandbox/iframe-popups-escape-sandbox.https.html
popup from sandboxed iframe with allow-popups-to-escape-sandbox flag does send client hint headers: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/sandbox/iframe-same-origin.https.html
Same origin sandboxed iframe with allow-same-origin flag does send client hint headers: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/sandbox/iframe.https.html
sandboxed iframe does not send client hint headers: FAIL (Chrome: PASS, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76939a593f67
[wpt PR 33656] - Migrate iframe-based Client Hint WPTs to import client hints lists, a=testonly

Comment 5

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/76939a593f67