Closed Bug 1764986 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33659 - Fix two show/hide bugs for <selectmenu> using <div popup>

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33659 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33659
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Fix two show/hide bugs for <selectmenu> using <div popup>

Fixed a bug for \<selectmenu> that kept the popup from being closed
if the listbox was provided via \<div popup=popup>. Also fixed a
related bug that caused selectmenu.open to return an incorrect value
in the same situation.

Bug: 1307772
Change-Id: I53b90e2381bc5d1a1f5ae94cb5ef4e60cf921a17
Fixed: 1316676
Reviewed-on: https://chromium-review.googlesource.com/3588854
WPT-Export-Revision: 01974521813e68f8b59f3a3c452647323d0725d3

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
FAIL : 5

Chrome

OK : 1
PASS : 4
FAIL : 1

Safari

ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative.html
Opening the popup and clicking an option should change the selectmenu's value: FAIL (Chrome: PASS)
With custom button and popup: opening the popup and clicking an option should change the selectmenu's value, old <popup> version: FAIL (Chrome: PASS)
With custom button and popup: opening the popup and clicking an option should change the selectmenu's value, new <div popup> version: FAIL (Chrome: FAIL)
Clicking a popup with no listbox part does nothing: FAIL (Chrome: PASS)
Clicking a popup with a listbox that was removed does nothing: FAIL (Chrome: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82f2d98662bf
[wpt PR 33659] - Fix two show/hide bugs for <selectmenu> using <div popup>, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1c346f51c487
[wpt PR 33659] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.