1765024 - Low resolution icons in newtab

Status: VERIFIED FIXED

(Toolkit :: Places, defect, P1)

Description

[tgn-ff]

Attachment: before-after.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

1. Pin https://www.mozilla.org/en-US/ and visit it.
2. Restart Nightly and observe its icon.
3. Open the same profile with Release.

Actual results:

A low resolution icon in Nightly but not in Release.

Expected results:

mozregression result:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=64eb6b660e816180fdcdd45ef20e03a67e4c3205&tochange=730361c8926b22f9ad4a5c9297293235ccfa2ca0

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1764275

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:mak, since you are the author of the regressor, bug 1764275, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Marco Bonardo [:mak]]

Hm, it sounds like there is some call passing 0 as size to a favicon API...
Probably here? https://searchfox.org/mozilla-central/rev/6da1ebe13b260efabd88eb98dec5fa8ee65987b2/browser/components/newtab/lib/FaviconFeed.jsm#42,49

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1765024 - Low resolution icons in newtab. r=daleharvey

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a058424d9dc4
Low resolution icons in newtab. r=daleharvey

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a058424d9dc4

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2022-04-15 Nightly build on Ubuntu 20.04. Verified as fixed on Firefox 101.0b6(20220512193916), Nightly 102.0a1(20220512213051) on Ubuntu 20.04, Win10 64-bits and macOS 11.