1765130 - [Upgrade spotlight] The bottom part of the "g" letter from the "gracias" string is cut off on Firefox es-ES locale

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: graciasString.PNG

[Affected versions]:

• Firefox Nightly 101.0a1 (Build ID: 20220417212536)
• Firefox Beta 100.0b7 (Build ID: 20220417185951)

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6.5
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest Firefox Beta 100 browser, es-ES build installed/extracted.
• Have the “devtools.chrome.enabled” pref set to true.
• Have the “Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog()” syntax copied to clipboard.
• Have a new Firefox profile.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Focus the browser console and run the syntax from prerequisites.
3. Observe the “gracias” string from the spotlight’s title.

[Expected result]:

• The “gracias” string is entirely visible.

[Actual result]:

• The bottom part of the “g” letter from the “gracias” string is cut off.

[Notes]:

• This issue is reproducible using all the browser’s themes.
• This “gracias” string is fully visible on High Contrast mode.
• Attached is a screenshot of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:
Should be fixed for Fx100 as it looks sloppy and not displaying complete message

Comment 2

[Ed Lee :Mardak]

Here's translations where es-* except es-ES happens to use title case avoiding the descender. But there's plenty of others that do descend. https://transvision.flod.org/string/?entity=browser/browser/newtab/onboarding.ftl:fx100-upgrade-thanks-header

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1765130 - [Upgrade spotlight] The bottom part of the "g" letter from the "gracias" string is cut off on Firefox es-ES locale r?mviar

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ecc134273ce
[Upgrade spotlight] The bottom part of the "g" letter from the "gracias" string is cut off on Firefox es-ES locale r=mviar

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1ecc134273ce

Comment 6

[Ed Lee :Mardak]

Comment on attachment 9272708 [details]
Bug 1765130 - [Upgrade spotlight] The bottom part of the "g" letter from the "gracias" string is cut off on Firefox es-ES locale r?mviar

Beta/Release Uplift Approval Request

• User impact if declined: Main headline text shown to users upgrading to 100 will have descenders (e.g., gjqpyęşქքχ) cut off. See attachment 9272672 [details]
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Changing CSS from fixed px length to a number
• String changes made/needed: none

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9272708 [details]
Bug 1765130 - [Upgrade spotlight] The bottom part of the "g" letter from the "gracias" string is cut off on Firefox es-ES locale r?mviar

Approved for 100.0b8

Comment 8

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 101.0a1 es-ES locale (Build ID: 20220418213528) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

• The headline from the upgrading spotlight is entirely visible.

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a9675f37313a

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using Firefox Beta 100.0b8 es-ES locale (Build ID: 20220419190903) on Windows 10 x64, macOS 11.6, and Linux Mint 20.2.

• The headline from the upgrading spotlight is entirely visible.