1765142 - "Shadows" are displayed above and under the "Get Firefox Focus" modal

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: shadows under the get firefox modal.png

[Affected versions]:

• Firefox Nightly 101.0a1 - Build ID: 20220417212536
• Firefox Beta 100.0b7 - Build ID: 20220417185951

[Affected Platforms]:

• Windows 10
• macOS 10.15.7
• Ubuntu 20.10

[Prerequisites]:

• Have a clean new Firefox profile.

[Steps to reproduce]:

1. Open the Browser with the profile from prerequisites.
2. Open a New Private Window.
3. Click the "Download Firefox Focus" button.
4. Observe the areas above and under the modal.

[Expected result]:

• No rendering differences can be observed.

[Actual result]:

• Shadows of the modal can be observed above and under it.

[Notes]:

• The issue is not reproducible on the Upgrading users Spotlight.
• Attached a screenshot of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

PBM specific issue not reproducible on about:welcome and upgrade spotlight, marking P2

Comment 2

[Ed Lee :Mardak]

Bug 1752935 adjusted window-modal spotlight has this box shadow none override: https://searchfox.org/mozilla-central/rev/f60e5304300b286376664b25143cdc6b38a0f0d7/browser/base/content/browser.css#1634-1635

So we might need to set the class and styling similarly for tab modal.

Comment 3

[Meg Viar [:mviar]]

Attachment: Bug 1765142 - "Shadows" are displayed above and under the "Get Firefox Focus" modal

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c72a63c84b2c
"Shadows" are displayed above and under the "Get Firefox Focus" modal r=Mardak

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c72a63c84b2c

Comment 6

[Carmen Fat [:cfat] - Ecosystem QA]

• I have verified this issue on the latest Nightly 102.0a1 (Build ID: 20220504093759) and Beta 101.0b2 (Build ID: 20220503185929) on Windows 10 x64, macOS 10.15.7, and Linux Ubuntu 20.04 x64.
• The shadows that were previously seen above and under the areas of the "Get Firefox Focus" modal are no longer displayed.