1765145 - The “Sign in” button is hardly visible if the browser is vertically resized and the “Dark” theme is enabled

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Cornel Bulz [cbulz],Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Beta 100.0b7 (Build ID: 20220417185951)
• Firefox Nightly 101.0a1 (Build ID: 20220417212536)

[Affected Platforms]:

• Windows 10 x64
• Linux Mint 20.3
• macOS 10.15.7

[Prerequisites]:

• Have the Firefox browser installed and opened.
• Have the browser’s default “Dark” theme enabled.

[Steps to reproduce]:

1. Navigate to the “about:welcome” page.
2. Resize the browser until the “Sign in” button overrides the black part of the Onboarding page.
3. Observe the “Sign in” button.

[Expected result]:

• The “Sign in” button is visible on the page.

[Actual result]:

• The “Sign in” button is hardly visible.

[Notes]:

• Attached is a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

Fx100 only fix that will be reverted back to original UX in Fx101. @jimt should we mark it won'tfix for Fx100 as it impacts signin CTA display on smaller browser width in dark theme

Comment 2

[Punam Dahiya [:pdahiya]]

Should be optimized to style that's independent of change in background image. We are well past Fx100 uplifts and fix can ride train.

Comment 3

[Meg Viar [:mviar]]

Attachment: Bug 1765145 - The “Sign in” button is hardly visible if the browser is vertically resized and the “Dark” theme is enabled

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7108e227ba8
The “Sign in” button is hardly visible if the browser is vertically resized and the “Dark” theme is enabled r=Mardak,emcminn

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d7108e227ba8

Comment 6

[Cornel Bulz [cbulz],Ecosystem QA]

I have verified that this issue is no longer reproducible using Firefox Nightly 102.0a1, (Build ID - 20220503094208) on LINUX Mint 20.3, Windows10 x64, macOS 12.3.1
The “Sign In” button is now visible when the browser is vertically resized and the Dark Theme is enabled.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This seems like a pretty low-risk uplift to take on Beta for Fx101. Please nominate the patch for approval if you agree.

Comment 8

[Meg Viar [:mviar]]

Appreciate you flagging this, Ryan. I've updated the bug to show as unaffected in FX101. This patch addresses an issue we saw with an onboarding message configuration specific to FX100. Those changes are reverted in FX101. The patch will make the first onboarding screen more flexible if we change the message configuration in the future, but ok to wait until FX102.

Comment 9

[Ed Lee :Mardak]

Bug 1763666 reverted to the Fx99 "sign in" link color