1765199 - should MozillaBuild still log user in when shell gets launched?

Status: RESOLVED DUPLICATE of bug 1762385

(Firefox Build System :: MozillaBuild, task)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Up to MozillaBuild 3.4, the console requested the user's SSH passphrase when launched::

REM Start shell.
IF "%USE_MINTTY%" == "1" (
  START %MOZILLABUILD%msys\bin\mintty -e %MOZILLABUILD%msys\bin\console %MOZILLABUILD%msys\bin\bash --login
) ELSE (
  IF "%*%" == "" (
    %MOZILLABUILD%msys\bin\bash --login -i
  ) ELSE (
    %MOZILLABUILD%msys\bin\bash --login -i -c "%*"
  )
)
EXIT /B

The login parameter got dropped from start-shell.bat in version 4.0:

REM Start shell.
IF "%USE_MINTTY%" == "1" (
  REM Opt into "ConPTY" support, which enables usage of win32 console binaries when
  REM running from mintty
  SET MSYS=enable_pcon
  %MOZILLABUILD%msys2\msys2_shell.cmd -full-path %*
) ELSE (
  %MOZILLABUILD%msys2\msys2_shell.cmd -no-start -defterm -full-path %*
)

EXIT /B

eval `ssh-agent.exe`

and

ssh-add

Personally, it feels cumbersome but with patches submitted via moz-phab, this might be reasonable as default.
Change made as part of https://hg.mozilla.org/mozilla-build/rev/e89b4156faf8f9f6cb046e1628bf3aeb599f1199#l81.63 / bug 1725895

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Ah, this is a bit confusing, but the root cause is different.

The login parameter got dropped from start-shell.bat in version 4.0:

We're not calling bash directly, we're now calling msys2_shell.cmd, which does still log the user in.

What's different is that we're no longer using the MSYS2 ssh by default (and starting its agent): instead, we're using Windows' built-in SSH.
Accordingly, we're adopting the same conventions as when using Windows' SSH from cmd/Powershell: if you want to use its agent, you need to configure the service in Windows.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The prompt got shown after gow got uninstalled.