1765307 - Unify Storage Access API logic between privileged and typical API

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P3)

Description

[Benjamin VanderSloot [:bvandersloot]]

There is a lot of logic in the Storage Access API calls on the document logic that is repeated. This bug concerns itself with Document::RequestStorageAccess and Document::RequestStorageAccessForOrigin.
These should have common logic broken into helper functions, preferrably in the anti-tracking module.

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1765307, part 1 - Create new context helper for requestStorageAccessForOrigin, r=#anti-tracking!

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1765307, part 2 - Convert privileged API to use helpers for the synchronous portion, r=#anti-tracking!

Depends on D146615

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1765307, part 3 - Create helper for the async portion of the requestStorageAccess[ForOrigin] functions, r=#anti-tracking!

Depends on D146616

Comment 4

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1765307, part 4 - Update requestStorageAccess[ForOrigin] functions to use helper functino for the asynchronous portion, r=#anti-tracking!

Depends on D146617

Comment 5

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1765307, part 5 - Make requestStorageAccessForOrigin check cookie permissions in the parent process, r=#anti-tracking!

Also remove the old IPC that did this.

Depends on D146618

Comment 6

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1765307, part 6 - Add inline comments to explain changes from this set, r=#anti-tracking!

Depends on D146946

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c341bc2a708
part 1 - Create new context helper for requestStorageAccessForOrigin, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/babee487e11f
part 2 - Convert privileged API to use helpers for the synchronous portion, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/351f1d3fd689
part 3 - Create helper for the async portion of the requestStorageAccess[ForOrigin] functions, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/417de8ef5343
part 4 - Update requestStorageAccess[ForOrigin] functions to use helper functino for the asynchronous portion, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/44991705d133
part 5 - Make requestStorageAccessForOrigin check cookie permissions in the parent process, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/56feedc5c0a3
part 6 - Add inline comments to explain changes from this set, r=anti-tracking-reviewers,timhuang

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0c341bc2a708
https://hg.mozilla.org/mozilla-central/rev/babee487e11f
https://hg.mozilla.org/mozilla-central/rev/351f1d3fd689
https://hg.mozilla.org/mozilla-central/rev/417de8ef5343
https://hg.mozilla.org/mozilla-central/rev/44991705d133
https://hg.mozilla.org/mozilla-central/rev/56feedc5c0a3

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

Backed out on dev's request. CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/59313dc4a54ebe419ecc2c2578a60bb3b188a19f

Comment 10

[Benjamin VanderSloot [:bvandersloot]]

Request made because I merged this during the soft code freeze. I'll re-merge Monday.

Comment 11

[Cristian Tuns]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/59313dc4a54e

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/347cb206479e
part 1 - Create new context helper for requestStorageAccessForOrigin, r=anti-tracking-reviewers,timhuang

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/347cb206479e

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09160a6522cd
part 2 - Convert privileged API to use helpers for the synchronous portion, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/202293397fb8
part 3 - Create helper for the async portion of the requestStorageAccess[ForOrigin] functions, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/8d2312dcd79f
part 4 - Update requestStorageAccess[ForOrigin] functions to use helper functino for the asynchronous portion, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/a58563979061
part 5 - Make requestStorageAccessForOrigin check cookie permissions in the parent process, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/be7ed002d159
part 6 - Add inline comments to explain changes from this set, r=anti-tracking-reviewers,timhuang

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/09160a6522cd
https://hg.mozilla.org/mozilla-central/rev/202293397fb8
https://hg.mozilla.org/mozilla-central/rev/8d2312dcd79f
https://hg.mozilla.org/mozilla-central/rev/a58563979061
https://hg.mozilla.org/mozilla-central/rev/be7ed002d159