1765310 - Break down SAA autogrant logic into named helper functions

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P3)

Description

[Benjamin VanderSloot [:bvandersloot]]

This should make reading the storage access calls easier and let us understand the ordering of our browser-specific language at a glance.

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1765310 - Break down SAA autogrant logic into named helper functions, r=#anti-tracking-reviewers!

Some reordering and pulling out the largest piece as a helper was all that needed to be done here.
This makes all stages more readable. I considered breaking up AntiTrackingUtils::CountStoragePermissions
further, but I think inline comments are sufficient

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77d4e91d37f5
Break down SAA autogrant logic into named helper functions, r=anti-tracking-reviewers,timhuang

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages on Document.cpp

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f038003e025
Break down SAA autogrant logic into named helper functions, r=anti-tracking-reviewers,timhuang

Comment 5

[Benjamin VanderSloot [:bvandersloot]]

Should have fixed the breakage with that last push.

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0f038003e025