1765313 - Move Storage Access API logic from ContentBlocking.h to its own file/folder in the AT module

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P3)

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1765313, part 1 - Remove dead code from ContentBlocking.h, r=#anti-tracking-reviewers!

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1765313, part 2 - Move the ShouldAllowAccessFor functions to StorageAccess.h, r=#anti-tracking-reviewers!

These functions are used to check if an object or context should have storage access.
Therefore they belong in StorageAccess.h with other functions that serve this purpose.

Depends on D148284

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1765313, part 3 - Rename ContentBlocking to StorageAccessAPIHelper, r=#anti-tracking-reviewers!

The only functions that remain are used as helper functions in the various variants of the Storage Access API.
To make this clearer, I have renamed this class and file that contains it.

Depends on D148285

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81a0f8c40381
part 1 - Remove dead code from ContentBlocking.h, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/f0895e88c27e
part 2 - Move the ShouldAllowAccessFor functions to StorageAccess.h, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/c76671d99573
part 3 - Rename ContentBlocking to StorageAccessAPIHelper, r=anti-tracking-reviewers,necko-reviewers,dragana,timhuang

Comment 5

[Sandor Molnar[:smolnar]]

Backed out 5 changesets (bug 1765313, bug 1770403) for causing lint failure in tools/lint/rejected-words.yml

Backout link: https://hg.mozilla.org/integration/autoland/rev/ab670f6df4832b577f1298f3a36d5790b06a524f

Push with failures

Failure log

Comment 6

[bszekely]

There is a new type of failure that appeared after the backout was done.

Failure line : TEST-UNEXPECTED-FAIL | /storage-access-api/requestStorageAccess.sub.window.html | [top-level-context] document.requestStorageAccess() should be rejected by default with no user gesture - assert_unreached: Should have rejected: document.requestStorageAccess() call without user gesture Reached unreachable code

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2376ca53eb9c
part 1 - Remove dead code from ContentBlocking.h, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/588d54f796a0
part 2 - Move the ShouldAllowAccessFor functions to StorageAccess.h, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/22153c8641e1
part 3 - Rename ContentBlocking to StorageAccessAPIHelper, r=anti-tracking-reviewers,necko-reviewers,dragana,timhuang

Comment 8

[Benjamin VanderSloot [:bvandersloot]]

Thanks for the heads up on the test failure. I resolved it by amending a patch further down the stack and resolved the lint error as well.

Comment 9

[Marian-Vasile Laza]

Backed out 5 changesets (Bug 1765313, Bug 1770403) for causing bc failures on browser_storageAccessPrivilegeAPI.js.
Backout link
Push with failures <--> bc3
Failure Log

Comment 10

[Benjamin VanderSloot [:bvandersloot]]

The fix for /storage-access-api/requestStorageAccess.sub.window.html caused this failure. I edited D147867 to resolve this.

I also re-tested locally, both browser chrome tests and wpt.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09ca524adf7d
part 1 - Remove dead code from ContentBlocking.h, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/7806f737966d
part 2 - Move the ShouldAllowAccessFor functions to StorageAccess.h, r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/b618f17c8f28
part 3 - Rename ContentBlocking to StorageAccessAPIHelper, r=anti-tracking-reviewers,necko-reviewers,dragana,timhuang

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/09ca524adf7d
https://hg.mozilla.org/mozilla-central/rev/7806f737966d
https://hg.mozilla.org/mozilla-central/rev/b618f17c8f28