1765452 - Move the trending icon used by about:newtab to the shared icon library in browser/themes/shared/icons

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P5)

Description

[Sam Foster [:sfoster] (he/him)]

browser/components/newtab/data/content/assets/glyph-trending-16.svg should be moved to browser/themes/shared/icons and named trending.svg.

• Please use hg mv or its git equivalent to move the file so we retain commit history.
• You will need to update the browser/themes/shared/jar.inc.mn manifest (please maintain alphabetical sorting) to include the new .svg
• You'll need to find and update all references to point at chrome://browser/skin/trending.svg
• See the docs for hacking on newtab for details on how to edit CSS and refresh the bundle

You should always build and run with your changes to verify them. In this case I don't believe there is an easy way to see the .icon-trending class in use, but you can check that chrome://browser/skin/trending.svg resolves to the correct icon when entered into the url bar.

Comment 1

[manisha270417]

Attachment: Bug 1765452 - Move and Rename the trending icon. r?sfoster

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:manisha.singh2019, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7da31c83b643
Move and Rename the trending icon. r=desktop-theme-reviewers,sfoster

Comment 4

[Sam Foster [:sfoster] (he/him)]

Helpful bot! Yeah this never got landed. I checked and it looks like it still merges ok..

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7da31c83b643