1765508 - Address bar does not convert negative temperatures

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[08xjcec48]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0

Steps to reproduce:

Typed -30C to F into the address bar.

Actual results:

Nothing.

Expected results:

It should give me the temperature in Fahrenheit, like it does with positive temperatures (30C to F).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Marco Bonardo [:mak]]

I assume this is with the unit conversion feature enabled (browser.urlbar.unitConversion.enabled set to true)?

Google suggestions seem to work for me, giving a read for both positive and negative temps.

Comment 3

[08xjcec48]

Yes, this is about the built-in feature. I don't use third-party suggestions.

The calculator works fine with negative numbers (-5+2), but the temperature converter (-30C to F) does not.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Thank you very much for your report, André!

Yes, I also could reproduce this problem.
And, it seems that I forgot to support negative numbers not only for temperature but other units..
I will fix it.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1765508: Support negative numbers for unit converter.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90b9c18398d8
Support negative numbers for unit converter. r=adw

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/90b9c18398d8

Comment 8

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Firefox 102 beta 5 across platforms, having browser.urlbar.unitConversion.enabled set to True.