Closed Bug 1765508 Opened 5 months ago Closed 5 months ago

Address bar does not convert negative temperatures

Categories

(Firefox :: Address Bar, defect)

defect

Tracking

()

VERIFIED FIXED
102 Branch
Tracking Status
firefox102 --- verified

People

(Reporter: 08xjcec48, Assigned: daisuke)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0

Steps to reproduce:

Typed -30C to F into the address bar.

Actual results:

Nothing.

Expected results:

It should give me the temperature in Fahrenheit, like it does with positive temperatures (30C to F).

Version: Firefox 99 → Trunk

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Address Bar

I assume this is with the unit conversion feature enabled (browser.urlbar.unitConversion.enabled set to true)?

Google suggestions seem to work for me, giving a read for both positive and negative temps.

Flags: needinfo?(emailmeat)
Flags: needinfo?(daisuke)

Yes, this is about the built-in feature. I don't use third-party suggestions.

The calculator works fine with negative numbers (-5+2), but the temperature converter (-30C to F) does not.

Flags: needinfo?(emailmeat)

Thank you very much for your report, André!

Yes, I also could reproduce this problem.
And, it seems that I forgot to support negative numbers not only for temperature but other units..
I will fix it.

Assignee: nobody → daisuke
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90b9c18398d8
Support negative numbers for unit converter. r=adw
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
QA Whiteboard: [qa-102b-p2]

Verified as fixed using Firefox 102 beta 5 across platforms, having browser.urlbar.unitConversion.enabled set to True.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.