1765515 - Changes to content-visibility should rebuild the frame

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martin Robinson (email:[e-mail])]

Since changes to content-visibility can change the used value of contain, it should trigger the at least as much difference as changes to the computed value of contain.

Comment 1

[Martin Robinson (email:[e-mail])]

Attachment: Bug 1765515 - Changes to content-visibility should rebuild the frame r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e154dcda079
Changes to content-visibility should rebuild the frame r=emilio

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2e154dcda079

Comment 4

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e154dcda079
Changes to content-visibility should rebuild the frame r=emilio

== Change summary for alert #33923 (as of Mon, 25 Apr 2022 05:42:40 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
24%	microsoft loadtime	windows10-64-shippable-qr	cold fission webrender	252.92 -> 314.42
19%	microsoft loadtime	linux1804-64-shippable-qr	cold fission webrender	334.62 -> 399.08
17%	ebay fcp	linux1804-64-shippable-qr	cold fission webrender	331.69 -> 387.75
17%	microsoft fcp	linux1804-64-shippable-qr	cold fission webrender	269.08 -> 313.62
14%	ebay fcp	macosx1015-64-shippable-qr	cold fission webrender	264.67 -> 301.88
14%	ebay fcp	windows10-64-shippable-qr	cold fission webrender	318.35 -> 362.88
13%	ebay loadtime	linux1804-64-shippable-qr	cold fission webrender	479.38 -> 543.96
13%	microsoft fcp	macosx1015-64-shippable-qr	cold fission webrender	189.17 -> 212.88
12%	microsoft loadtime	macosx1015-64-shippable-qr	cold fission webrender	271.25 -> 302.75
11%	microsoft SpeedIndex	windows10-64-shippable-qr	cold fission webrender	669.17 -> 742.75
...	...	...	...	...
7%	microsoft LastVisualChange	windows10-64-shippable-qr	cold fission webrender	875.25 -> 939.17
7%	microsoft PerceptualSpeedIndex	windows10-64-shippable-qr	cold fission webrender	482.92 -> 515.50
5%	microsoft PerceptualSpeedIndex	macosx1015-64-shippable-qr	cold fission webrender	459.79 -> 484.83
4%	ebay PerceptualSpeedIndex	windows10-64-shippable-qr	cold fission webrender	1,162.50 -> 1,204.33
3%	ebay SpeedIndex	windows10-64-shippable-qr	cold fission webrender	1,433.58 -> 1,478.17

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33923

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Can you file a bug for those regressions? They're unexpected.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Also, are you sure this change is the culprit? It only does changes to a disabled-by-default feature.

Comment 7

[Martin Robinson (email:[e-mail])]

This is pretty mysterious. I just double-checked that this code should not be triggered at all when loading these pages (or changing the property in question manually) when the feature flag is disabled.

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Sorry, emilio, I concluded that this was caused by infra changes.