Closed
Bug 1765632
Opened 2 years ago
Closed 2 years ago
Refactor ReflowInput::CalculateHypotheticalPosition to combine boxISize and knowBoxISize into Maybe<nscoord>
Categories
(Core :: Layout: Positioned, task)
Core
Layout: Positioned
Tracking
()
RESOLVED
FIXED
101 Branch
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
When reading some code in ReflowInput::CalculateHypotheticalPosition just now, I noticed boxISize and knowBoxISize are essentially behaving as a Maybe<nscoord>.
I'm filing this bug on combining these variables to use Maybe, for simplicity and for better guarantees that Maybe provides (against inadvertent reassignment via repeated emplace(), and against uninitialized usage).
|
Assignee | |
Comment 1•2 years ago
|
||
This patch shouldn't change behavior; it's just refactoring/simplifying
existing code, without changing the logic.
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/322c13b909bf Coalesce two variables into one Maybe<> variable, in ReflowInput::CalculateHypotheticalPosition. r=dshin
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox101:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•