Closed Bug 1765635 Opened 3 years ago Closed 3 years ago

Extract the panel-list element from aboutaddons.js

Categories

(Toolkit :: UI Widgets, task, P3)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: mstriemer, Assigned: mstriemer, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 file, 1 obsolete file)

The panel-list (and related elements) in aboutaddons.js provide a general use menu for in-content pages. It would be nice if this was extracted into our widgets folder for reuse in other places such as about:logins, about:newtab and potentially even devtools.

Let's add it to storybook from bug 1765634 at the same time.

Blocks: storybook
Whiteboard: [fidefe-reusable-components-ms1]
Blocks: moz-menu
No longer blocks: reusable-components
No longer blocks: storybook

Add some inline padding and border radius around menu items similar to menus in
the chrome. Use 4px values since that's more standard than 6px for us.

Depends on D144224

Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da24ae3723ce Extract panel-list from aboutaddons to widgets r=mconley

Backed out for causing bc failures on browser_html_detail_view.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js | Uncaught exception in test - at chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js:364 - TypeError: can't access property "hidden", separator is null
Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bec193e3e12b Extract panel-list from aboutaddons to widgets r=mconley
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Regressions: 1810004
Attachment #9309286 - Attachment is obsolete: true
Whiteboard: [fidefe-reusable-components-ms1] → [recomp]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: