Closed Bug 1765732 Opened 3 years ago Closed 2 years ago

Make ContentParent::ShutDownProcess fallible in case of failed dispatch

Categories

(Core :: DOM: Content Processes, task, P3)

task

Tracking

()

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: jstutte, Assigned: aiunusov)

References

Details

Attachments

(2 files)

ContentParent::ShutDownProcess currently does not give any return value if the dispatching of the shutdown messages was successful or not. This makes it impossible to avoid potential races 100% (even if we check CanSend() before calling it that might change in the time frame we need to arrive at the real dispatch) and might leave us to believe we need to wait for a process shutdown that will never happen.

We should make it return a boolean if the dispatch was successful or not, just like a normal dispatch function.

Priority: -- → P3
See Also: → 1764251
Assignee: nobody → aiunusov
Attachment #9304721 - Attachment description: WIP: Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug → Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug
Attachment #9304721 - Attachment description: Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug → WIP: Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug
Attachment #9304721 - Attachment description: WIP: Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug → Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug
Attachment #9304721 - Attachment description: Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug → WIP: Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug
Attachment #9304721 - Attachment description: WIP: Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug → Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65b98515f2ce Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch

prevent resource leak). r=smaug

Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/acbc96016140 Use KillHard() in case of failed dispatch (in order to r=smaug

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: