1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P3)

Description

[Jens Stutte [:jstutte]]

ContentParent::ShutDownProcess currently does not give any return value if the dispatching of the shutdown messages was successful or not. This makes it impossible to avoid potential races 100% (even if we check CanSend() before calling it that might change in the time frame we need to arrive at the real dispatch) and might leave us to believe we need to wait for a process shutdown that will never happen.

We should make it return a boolean if the dispatch was successful or not, just like a normal dispatch function.

Comment 1

[Artur Iunusov]

Attachment: Bug 1765732 - Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65b98515f2ce
Make ContentParent::ShutDownProcess fallible in case of failed dispatch, r=smaug

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/65b98515f2ce

Comment 4

[Artur Iunusov]

Attachment: Bug 1765732 - Use KillHard() in case of failed dispatch (in order to

prevent resource leak). r=smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acbc96016140
Use KillHard() in case of failed dispatch (in order to r=smaug

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/acbc96016140

Comment 7

[Release mgmt bot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)