1765737 - Stop passing per-JSM global this to Cu.cloneInto

Status: RESOLVED FIXED

(Toolkit :: General, task)

Description

[Tooru Fujisawa [:arai]]

The 2nd parameter of Cu.cloneInto is a scope, that's used only for JSAutoRealm.
It's not necessary to be global this, but anything belongs to the same realm works.

Comment 1

[Tooru Fujisawa [:arai]]

So far, confirmed the following code passes global this:

• toolkit/components/extensions/ExtensionStorageSyncKinto.jsm
• toolkit/components/extensions/Schemas.jsm
• toolkit/components/telemetry/app/TelemetryEnvironment.jsm
• toolkit/components/telemetry/pings/TelemetrySession.jsm

So, moving this to Toolkit product for now.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765737 - Part 1: Pass an empty object instead of global this to Cu.cloneInto in toolkit/components/extensions/. r?rpl!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765737 - Part 2: Pass an empty object instead of global this to Cu.cloneInto in toolkit/components/telemetry/. r?chutten!

Depends on D144783

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f96cbf5d0c1b
Part 1: Pass an empty object instead of global this to Cu.cloneInto in toolkit/components/extensions/. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/df6966a0f41d
Part 2: Pass an empty object instead of global this to Cu.cloneInto in toolkit/components/telemetry/. r=chutten

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f96cbf5d0c1b
https://hg.mozilla.org/mozilla-central/rev/df6966a0f41d