Closed
Bug 1765773
Opened 3 years ago
Closed 3 years ago
Simplify and optimize GetThisObject code in InternalCall
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
101 Branch
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(3 files)
No description provided.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
In most cases, the |this| object isn't a global and in that case we don't have
to do anything.
Depends on D144287
|
|
Assignee | |
Comment 3•3 years ago
|
||
InternalCall has two callers and only one of them needs this extra step.
CallFromStack is used for calls from JS and Window is never exposed to script.
Depends on D144288
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81fd602e5734
part 1 - Add CalleeNeedsOuterizedThisObject helper function. r=iain
https://hg.mozilla.org/integration/autoland/rev/c1e736b307ac
part 2 - Add a fast path for non-global-objects. r=iain
https://hg.mozilla.org/integration/autoland/rev/a24321b66582
part 3 - Move outerization into the caller that needs it. r=iain
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/81fd602e5734
https://hg.mozilla.org/mozilla-central/rev/c1e736b307ac
https://hg.mozilla.org/mozilla-central/rev/a24321b66582
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox101:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•