1765922 - Use single static buffer when capturing stacks for main-thread markers in child processes

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Bug 1734867 added a single static buffer for capturing stacks in main-thread markers, however it was only effectively enabled in the parent process, because that buffer must be allocated from the main thread, but in child processes that call is done from a non-main thread -- this should be improved.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1765922 - Ensure/ReleaseBufferForMainThreadAddMarker from main thread in profiler_start/stop - r?canaltinova

In child processes, Gecko Profiler's profiler_start/stop are running OFF the main thread, so the calls to Ensure/ReleaseBufferForMainThreadAddMarker should be dispatched to the main thread for them to actually create/destroy the main-thread buffer.

Note that this is not done in the Base Profiler, because it should always run on the main thread, and if it wasn't there would be no way to dispatch a task to the main thread -- and it wouldn't be too much of an issue anyway, there are few markers running outside of Gecko Profiler sessions.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5ff969a3d72
Ensure/ReleaseBufferForMainThreadAddMarker from main thread in profiler_start/stop - r=florian

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a5ff969a3d72