1765992 - Support regular and static operations with the same identifier

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task)

Description

[Edgar Chen [:edgar]]

The WebIDL change is in https://github.com/whatwg/webidl/pull/1098.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Bug 1765992 - Support regular and static WebIDL operations with the same identifier; r=peterv

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Peter: this is the bug I was asking about - with the stack up to https://phabricator.services.mozilla.com/D171217 , the assertion triggers when running toolkit/components/cleardata/tests/browser/browser_preflight_cache.js.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to :Ms2ger (he/him; ⌚ UTC+1/+2) from comment #2)

Peter: this is the bug I was asking about - with the stack up to https://phabricator.services.mozilla.com/D171217 , the assertion triggers when running toolkit/components/cleardata/tests/browser/browser_preflight_cache.js.

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Bug 1765992 - Support regular and static WebIDL operations with the same identifier on the same interface. r?edgar!

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: Bug 1765992 - Support regular and static WebIDL operations with the same identifier, additional test. r?edgar!

Depends on D171216

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: Bug 1765992 - Fix WebIDL Xrays to properly deal with a static and non-static property with the same name. r?edgar!

Depends on D171704

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae92922b3b3a
Support regular and static WebIDL operations with the same identifier; r=peterv
https://hg.mozilla.org/integration/autoland/rev/70ee010fff60
Support regular and static WebIDL operations with the same identifier on the same interface. r=edgar
https://hg.mozilla.org/integration/autoland/rev/3861a5ec6941
Fix WebIDL Xrays to properly deal with a static and non-static property with the same name. r=edgar

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for causing WebIDLError linting opt failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=3861a5ec6941202eaefbb1f06ac330ee3d883c40&selectedTaskRun=YcFe2cFtQKq54R7Ud_oAFQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=409022002&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/a226cc91e0c3148c9ff37cb4d971c1196a0571cc

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4b61f52eb59
Support regular and static WebIDL operations with the same identifier; r=peterv
https://hg.mozilla.org/integration/autoland/rev/605a523fd68f
Support regular and static WebIDL operations with the same identifier on the same interface. r=edgar
https://hg.mozilla.org/integration/autoland/rev/f1557bbb7e52
Fix WebIDL Xrays to properly deal with a static and non-static property with the same name. r=edgar

Comment 10

[Serban Stanca [:SerbanS]]

Backed out for causing multiple failures.

• Backout link

---

• Push with failures - mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | remote/shared/listeners/test/browser/browser_ConsoleAPIListener.js | Uncaught exception in test bound test_method_and_arguments - at chrome://mochitests/content/browser/remote/shared/listeners/test/browser/browser_ConsoleAPIListener.js:110 - TypeError: can't access property "apply", content.console[_method] is undefined

---

• Push with failures - reftests failures
• Failure Log
• Failure line: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/forms/input/text/pseudo-class-lock.html == layout/reftests/forms/input/text/pseudo-class-lock-ref.html | image comparison, max difference: 56, number of differing pixels: 432

---

• Push with failures - another mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/tests/browser/browser_ConsoleStorageAPITests.js | Uncaught exception in test bound - TypeError: content.console.log is not a function

---

• Push with failures - devtools failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_addNode_01.js | Test timed out -

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53c9686092a3
Support regular and static WebIDL operations with the same identifier; r=peterv
https://hg.mozilla.org/integration/autoland/rev/5fc5eed227e0
Support regular and static WebIDL operations with the same identifier on the same interface. r=edgar
https://hg.mozilla.org/integration/autoland/rev/038e9ee2a638
Fix WebIDL Xrays to properly deal with a static and non-static property with the same name. r=edgar

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/53c9686092a3
https://hg.mozilla.org/mozilla-central/rev/5fc5eed227e0
https://hg.mozilla.org/mozilla-central/rev/038e9ee2a638